staticdata: Memoize type_in_worklist query
#57917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topolarity
added
backport 1.10
vtjnash
reviewed
Mar 28, 2025
When pre-compiling `stdlib/` this cache has a 91% hit rate, so this seems
fairly profitable. It also dramatically improves some pathological cases,
a few of which have been hit in the wild (arguably due to inference bugs)
Without this PR, this package takes exponentially long to pre-compile:
```julia
function BigType(N)
(N == 0) && return Nothing
T = BigType(N-1)
return Pair{T,T}
end
foo(::Type{T}) where T = T
precompile(foo, (Type{BigType(40)},))
```
topolarity
force-pushed
the
ct/memoize-staticdata
branch
from
f09789a to
f0b3460
Compare
JeffBezanson
added
compiler:precompilation
JeffBezanson
approved these changes
Mar 28, 2025
KristofferC
pushed a commit
that referenced
this pull request
Mar 31, 2025
When pre-compiling `stdlib/` this cache has a 91% hit rate, so this
seems fairly profitable. It also dramatically improves some pathological
cases, a few of which have been hit in the wild (arguably due to
inference bugs)
Without this PR, this package takes exponentially long to pre-compile:
```julia
function BigType(N)
(N == 0) && return Nothing
T = BigType(N-1)
return Pair{T,T}
end
foo(::Type{T}) where T = T
precompile(foo, (Type{BigType(40)},))
```
For an in-the-wild test case hit by a customer, this reduces
pre-compilation time from over an hour to just ~two and a half minutes.
Resolves #53331.
(cherry picked from commit 89271dc)
KristofferC
pushed a commit
that referenced
this pull request
Mar 31, 2025
When pre-compiling `stdlib/` this cache has a 91% hit rate, so this
seems fairly profitable. It also dramatically improves some pathological
cases, a few of which have been hit in the wild (arguably due to
inference bugs)
Without this PR, this package takes exponentially long to pre-compile:
```julia
function BigType(N)
(N == 0) && return Nothing
T = BigType(N-1)
return Pair{T,T}
end
foo(::Type{T}) where T = T
precompile(foo, (Type{BigType(40)},))
```
For an in-the-wild test case hit by a customer, this reduces
pre-compilation time from over an hour to just ~two and a half minutes.
Resolves #53331.
(cherry picked from commit 89271dc)
topolarity
added a commit
that referenced
this pull request
Apr 1, 2025
When pre-compiling `stdlib/` this cache has a 91% hit rate, so this
seems fairly profitable. It also dramatically improves some pathological
cases, a few of which have been hit in the wild (arguably due to
inference bugs)
Without this PR, this package takes exponentially long to pre-compile:
```julia
function BigType(N)
(N == 0) && return Nothing
T = BigType(N-1)
return Pair{T,T}
end
foo(::Type{T}) where T = T
precompile(foo, (Type{BigType(40)},))
```
For an in-the-wild test case hit by a customer, this reduces
pre-compilation time from over an hour to just ~two and a half minutes.
Resolves #53331.
topolarity
added a commit
that referenced
this pull request
Apr 1, 2025
When pre-compiling `stdlib/` this cache has a 91% hit rate, so this
seems fairly profitable. It also dramatically improves some pathological
cases, a few of which have been hit in the wild (arguably due to
inference bugs)
Without this PR, this package takes exponentially long to pre-compile:
```julia
function BigType(N)
(N == 0) && return Nothing
T = BigType(N-1)
return Pair{T,T}
end
foo(::Type{T}) where T = T
precompile(foo, (Type{BigType(40)},))
```
For an in-the-wild test case hit by a customer, this reduces
pre-compilation time from over an hour to just ~two and a half minutes.
Resolves #53331.
topolarity
removed
backport 1.10
KristofferC
pushed a commit
that referenced
this pull request
Jun 5, 2025
When pre-compiling `stdlib/` this cache has a 91% hit rate, so this
seems fairly profitable. It also dramatically improves some pathological
cases, a few of which have been hit in the wild (arguably due to
inference bugs)
Without this PR, this package takes exponentially long to pre-compile:
```julia
function BigType(N)
(N == 0) && return Nothing
T = BigType(N-1)
return Pair{T,T}
end
foo(::Type{T}) where T = T
precompile(foo, (Type{BigType(40)},))
```
For an in-the-wild test case hit by a customer, this reduces
pre-compilation time from over an hour to just ~two and a half minutes.
Resolves #53331.
KristofferC
pushed a commit
that referenced
this pull request
Jul 3, 2025
When pre-compiling `stdlib/` this cache has a 91% hit rate, so this
seems fairly profitable. It also dramatically improves some pathological
cases, a few of which have been hit in the wild (arguably due to
inference bugs)
Without this PR, this package takes exponentially long to pre-compile:
```julia
function BigType(N)
(N == 0) && return Nothing
T = BigType(N-1)
return Pair{T,T}
end
foo(::Type{T}) where T = T
precompile(foo, (Type{BigType(40)},))
```
For an in-the-wild test case hit by a customer, this reduces
pre-compilation time from over an hour to just ~two and a half minutes.
Resolves #53331.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pre-compiling
stdlib/this cache has a 91% hit rate, so this seems fairly profitable. It also dramatically improves some pathological cases, a few of which have been hit in the wild (arguably due to inference bugs)Without this PR, this package takes exponentially long to pre-compile:
For an in-the-wild test case hit by a customer, this reduces pre-compilation time from over an hour to just ~two and a half minutes.
Resolves #53331.