better behaved loading errors #57727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
packages
Needs news? |
KristofferC
reviewed
Mar 12, 2025
vtjnash
force-pushed
the
jn/using-moduleroot
branch
from
bf1d741 to
2b33557
Compare
… itself) without dot Also clean up and fix some related manual errata that had become incorrect over time.
…create a module Avoids a discrepency in behavior between direct loading and precompile
vtjnash
force-pushed
the
jn/using-moduleroot
branch
from
2b33557 to
7a9c7cc
Compare
KristofferC
pushed a commit
that referenced
this pull request
Mar 21, 2025
3 interrelated fixes here: - Re-word the confusing error message for a circular dependency error. - Calling `using` inside a package was previously declared to be an error, but never really enforced, so allow it explicitly to do what it logically means (when appearing explicitly, such as from having `Requires.@require` in an `__init__` function). Remove the associated warning in the docs, since this gotcha now simply means what users think it would mean. - A missing lock acquire in create_expr_cache lead to a confusing discrepancy in errors related to the previous two fixes between incremental and serial modes. Fixes #56742 (cherry picked from commit 7f8ca29)
KristofferC
removed
the
backport 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 interrelated fixes here:
usinginside a package was previously declared to be an error, but never really enforced, so allow it explicitly to do what it logically means (when appearing explicitly, such as from havingRequires.@requirein an__init__function). Remove the associated warning in the docs, since this gotcha now simply means what users think it would mean.Fixes #56742