make using Foo in package Foo equivalent to using .Foo.
#57728
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so applies to submodules where the package module is directly returned instead of doing a full environment lookup. This allows e.g. packages that fail to precompile and load themselves to not load themselves circularly and more similarly matches the behavior of code being precompiled. It should also be better for performance since there is no need to start looking through environment files.
KristofferC
added
packages
|
Sniped by #57727. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also applies to submodules where the package module is directly returned instead of doing a full environment lookup.
This allows e.g. packages that fail to precompile and load themselves to not load themselves circularly and more similarly matches the behavior of code being precompiled. It should also be better for performance since there is no need to start looking through environment files.
Should fix some PkgEval failures, for example:
https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/10f5d44_vs_aae2243/GeneralizedMonteCarlo.primary.log
or
https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/10f5d44_vs_aae2243/YaoBase.primary.log.