Skip to content

make using Foo in package Foo equivalent to using .Foo. #57728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

make using Foo in package Foo equivalent to using .Foo. #57728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions base/loading.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2383,6 +2383,10 @@ function __require(into::Module, mod::Symbol)
error("`using/import $mod` outside of a Module detected. Importing a package outside of a module \
is not allowed during package precompilation.")
end
topmod = moduleroot(into)
if nameof(topmod) === mod
return topmod
end
@lock require_lock begin
LOADING_CACHE[] = LoadingCache()
try
Expand Down
15 changes: 15 additions & 0 deletions test/precompile.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2360,4 +2360,19 @@ precompile_test_harness("MainImportDisallow") do load_path
end
end

precompile_test_harness("Package top-level load itself") do load_path
write(joinpath(load_path, "UsingSelf.jl"),
"""
__precompile__(false)
module UsingSelf
using UsingSelf
x = 3
end
""")
@eval using UsingSelf
invokelatest() do
@test UsingSelf.x == 3
end
end

finish_precompile_test!()