-
Notifications
You must be signed in to change notification settings - Fork 33
Commonizing code between Fixed
and Normed
#139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This comment has been minimized.
This comment has been minimized.
Commonize code between `Fixed` and `Normed` (the first part of #139)
Steps 1 and 2 are almost complete. Step 0 (the coding guidelines) is partially unfinished. Step 3 has not been started yet. I will keep this issue open until we have a concrete work plan. |
I thought the test code was difficult to commonize. However, as I'll add tests for arithmetic operations, I am not very satisfied with the current test code. A practical problem is the long testing times. It's not fatal at the moment, but it should be an obstacle to supporting signed julia> target(Normed, (:i8, :i16), :light)
(N7f1, N1f7, N0f8, N15f1, N9f7, N8f8, N7f9, N6f10, N5f11, N1f15, N0f16) |
We can use I devised (ugly) small macros like this: The pair of macros |
The support for checked basic four operations is almost complete. Now that I know that those 100% tests are common to |
Fixed
andNormed
have evolved independently. Therefore, some functions are specialized even though they do not need specialization.cf.
ee5bd54...kimikage:commonizePR #151I'm going to refactor the codes by taking the following 3 steps.
Fixed
)Although "test-first" is a good practice, the step 3. requires major renovations. Please give me your advice if you have any ideas.
The text was updated successfully, but these errors were encountered: