Skip to content

Commonize test codes #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Conversation

kimikage
Copy link
Collaborator

@kimikage kimikage commented Aug 30, 2020

This also fixes some tests to follow the printing style change on v1.6.0-DEV.

Closes #139. (There is still room for generalization, though.)

This also fixes some tests to follow the printing style change on v1.6.0-DEV.
@codecov
Copy link

codecov bot commented Aug 30, 2020

Codecov Report

Merging #224 into master will decrease coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
- Coverage   91.79%   91.46%   -0.34%     
==========================================
  Files           6        6              
  Lines         573      574       +1     
==========================================
- Hits          526      525       -1     
- Misses         47       49       +2     
Impacted Files Coverage Δ
src/normed.jl 92.26% <0.00%> (-1.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a142308...0d86ab4. Read the comment docs.

Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on avoiding type specialization on the test functions.

@kimikage kimikage merged commit 7f6575e into JuliaMath:master Aug 31, 2020
@kimikage kimikage deleted the common_totaltest branch August 31, 2020 13:54
@kimikage kimikage mentioned this pull request Apr 30, 2024
38 tasks
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commonizing code between Fixed and Normed
2 participants