Skip to content

Problems with conversions from Rational #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kimikage opened this issue Dec 28, 2019 · 0 comments · Fixed by #169
Closed

Problems with conversions from Rational #157

kimikage opened this issue Dec 28, 2019 · 0 comments · Fixed by #169

Comments

@kimikage
Copy link
Collaborator

Normed supports the conversion to Rational, but does not support the conversion from Rational.

julia> N0f8(1//2)
ERROR: MethodError: no method matching unsafe_trunc(::Type{UInt8}, ::Rational{Int64})

Fixed supports the conversion from Rational, but it overflows too easily.

julia> Q0f7(1//2)
ERROR: InexactError: trunc(Int8, 128)

FixedPointNumbers.jl/src/fixed.jl

Line 15 in 7ad0f0c

Fixed{T,f}(x::Rational) where {T,f} = Fixed{T,f}(x.num)/Fixed{T,f}(x.den)

This was referenced Dec 29, 2019
Merged
Merged
@kimikage kimikage mentioned this issue Jan 16, 2020
Merged
kimikage added a commit that referenced this issue Jan 21, 2020
@kimikage
Add support for Normed construction from Rational (Fixes #157) (#169
cb29336 
)

This also fixes the overflow problem with `Fixed` construction from `Rational`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Normed construction from Rational (Fixes #157) kimikage/FixedPointNumbers.jl
1 participant
@kimikage