Add rounding functions for Fixed (Fixes #153)
#158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also simplifies the test for rounding functions.
|
Let's merge this before #163 |
The functions support `Fixed{Int8,8}` and so on, for now.
|
Though I merged PR #159, this PR supports |
timholy
approved these changes
Jan 11, 2020
kimikage
commented
Jan 11, 2020
Comment on lines
+106
to
+109
| function floor(x::Fixed{T,f}) where {T, f} | ||
| f == bitwidth(T) && x.i < 0 && throw_converterror(Fixed{T,f}, -1) # TODO: remove this line | ||
| Fixed{T,f}(x.i & intmask(x), 0) | ||
| end |
There was a problem hiding this comment.
I would like to confirm just in case, your implementation is much more complex.
FixedPointNumbers.jl/src/fixed.jl
Lines 92 to 96 in ebc5eff
Am I overlooking something?
(I'm sleepy now, so the decision for merging is pending. Feel free to merge this.:sleepy:)
There was a problem hiding this comment.
No, you're absolutely right, the simpler one looks correct. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of #151 and fixes #153.
succeeding PRs: this ->
isinteger(#120) ->rem(#150) ->Integer(#154) ->Rational(#157)Edit:
Let's decide #159 first.Done.