Systemize fixed point types to be tested #208
Conversation
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
- Coverage 89.83% 89.21% -0.63%
==========================================
Files 6 6
Lines 482 482
==========================================
- Hits 433 430 -3
- Misses 49 52 +3
Continue to review full report at Codecov.
|
|
Due to code movement this won't be easy to review, and it doesn't look like it's much in need anyway. So just go ahead and merge when you're ready. |
|
Thank you for your response. Most of the code movement is not important, but I don't want to mess with the arrangement every time I add a test set. 😅 The essential change in this PR is |
|
Test performance is definitely important. Maybe add a little bit of commentary about the heavy/default/thin/light system? Just from reading it's not entirely obvious since the |
kimikage
force-pushed
the
reorder_testsets
branch
from
8586afc to
e923cb8
Compare
kimikage
force-pushed
the
reorder_testsets
branch
from
e923cb8 to
837bc9c
Compare
|
I moved the |
|
LGTM! |
This abstracts the selection of the types to be tested and makes it more systematic. As a result, we can reduce impractical test cases (e.g. for the 128-bit types) without significantly compromising the test quality. This also reorders some test sets.
This abstracts the selection of the types to be tested and makes it more systematic. As a result, we can reduce impractical test cases (e.g. for the 128-bit types) without significantly compromising the test quality. This also reorders some test sets.
This abstracts the selection of the types to be tested and makes it more systematic. As a result, we can reduce impractical test cases (e.g. for the 128-bit types) without significantly compromising the test quality. This also reorders some test sets.
This abstracts the selection of the types to be tested and makes it more systematic. As a result, we can reduce impractical test cases (e.g. for the 128-bit types) without significantly compromising the test quality. This also reorders some test sets.
cf. #139 (comment)
This does not commonize the tests between
FixedandNormed, but does prepare for the commonization.