Updating reflect.lite to the new kotlinx.metadata.jvm #19

mvicsokolova · 2022-01-13T22:47:46Z

No description provided.

dkhalanskyjb · 2022-01-14T12:42:15Z

src/main/java/kotlinx/reflect/lite/KAnnotatedElement.kt

+ * See the [Kotlin language documentation](https://kotlinlang.org/docs/reference/annotations.html)
+ * for more information.
+ */
+public interface KAnnotatedElement {


Yeah, since the end goal is to re-implement the interfaces from the reflect library, the approach is good.

src/main/java/kotlinx/reflect/lite/KAnnotatedElement.kt

src/main/java/kotlinx/reflect/lite/KCallable.kt

src/main/java/kotlinx/reflect/lite/impl/KCallableImpl.kt

src/test/java/kotlinx/reflect/lite/test/BasicReflectTest.kt

dkhalanskyjb · 2022-01-14T14:23:57Z

Looking more closely, I don't think these interfaces are what we want. KClass, KCallable, etc., are all already present in the standard library. For example, just doing import kotlin.reflect.KCallable already gives access to KCallable, even inside this project. What we need is to reimplement this API: https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.reflect.full/ (https://github.com/JetBrains/kotlin/tree/master/core/reflection.jvm/src/kotlin/reflect/full)

dkhalanskyjb · 2022-01-17T10:48:48Z

On the second thought, the approach of having our own copies of the interfaces can also be good. The kotlin-reflect library assumes that only it implements the interfaces from the standard library and will give wrong answers if it's not the case. For example, https://github.com/JetBrains/kotlin/blob/1b49105c78c566ec42b422cbd46782b47a0d9f40/core/reflection.jvm/src/kotlin/reflect/jvm/ReflectJvmMapping.kt#L40.

So, maybe we should keep our own copies for now. Reverting to the ones from the standard library shouldn't be difficult if we want to later.

src/main/java/kotlinx/reflect/lite/builtins/JavaToKotlinClassMap.kt

dkhalanskyjb · 2022-02-14T13:47:41Z

src/main/java/kotlinx/reflect/lite/builtins/JavaToKotlinClassMap.kt

+import kotlinx.reflect.lite.misc.*
+import kotlinx.reflect.lite.name.*
+
+object JavaToKotlinClassMap {


This should be internal, right? What do you think about enabling the API mode now so that there's no chance that objects like this will leak to the API?

Yes, this is definitely internal. I'll add explicitApi check 👌🏻

dkhalanskyjb · 2022-02-14T14:02:42Z

src/main/java/kotlinx/reflect/lite/builtins/KotlinBuiltIns.kt

+
+    val FQ_NAMES = FqNames()
+    class FqNames {
+        val array = FqName("kotlin.Array")


Taken from here https://github.com/JetBrains/kotlin/blob/master/core/compiler.common/src/org/jetbrains/kotlin/builtins/StandardNames.kt#L82, right?

Yes, I'll add the note

Please do, it will make reviewing the PR a lot easier. I'll easily see what is just a copy-paste of code that may be boilerplate-y is just used for its facilities, and what is the actual crux of the solution.

This is more relevant than ever. I'm quite lost in the codebase now.

Added KotlinCommonMetadata for reading metadata from .kotlin_builtins file

…nProperty WIP

- fix valueParameters for accessors - support access to private properties via the javaField

Implemented: - KProperty<*>.javaGetter - KMutableProperty<*>.javaSetter - KFunction<*>.javaMethod - KCallable<*>.isAccessible

…te and kotlin.reflect on the expected use-case from "incorrectNumberOfArguments" test

src/main/java/kotlinx/reflect/lite/impl/KClasses.kt

…classes: `Class<T>.kotlin` and `KClass<T>.java` API

….jvm

qwwdfsad

Yay!

mvicsokolova added 2 commits January 12, 2022 14:25

Migrate project to gradle

8e3daed

Initial commit: introduced basic API consistent with reflect-full

6c0aa0d

dkhalanskyjb reviewed Jan 14, 2022

View reviewed changes

mvicsokolova added 3 commits January 17, 2022 19:25

All the reflect interfaces copied from the stdlib.

8c02d69

Implementation of reflect API via descriptors

315d2a0

Descriptors for reflection entities

c42939c

dkhalanskyjb reviewed Feb 14, 2022

View reviewed changes

mvicsokolova added 6 commits February 16, 2022 22:07

Update kotlinx-metadata-jvm to 0.4.2

04d7b75

Added KotlinCommonMetadata for reading metadata from .kotlin_builtins file

Consistent way to delegate KClass implementation to ClassDescriptor

1184613

Some tests for parameter and type api

3f84f57

Update Kotlin to 1.7.10

7876740

Support inherited class members

5dc9c07

KCallable: call, callBy

a5276f0

mvicsokolova force-pushed the mvicsokolova/dev branch from c830d2f to a5276f0 Compare July 18, 2022 08:35

mvicsokolova added 14 commits July 19, 2022 13:47

Copy source notes

d02ab87

Class member properties implemented: KProperty0<V>, KProperty1<T, V>

bb632b9

Java to Kotlin reflection mapping: kotlinClass, kotlinFunction, kotli…

8fe9422

…nProperty WIP

Kotlin to Java reflection: KProperty<*>.javaField

50f0005

Fix tests for KProperty accessors

0864056

some test fixes

3e6788f

KProperty:

d9a8667

- fix valueParameters for accessors - support access to private properties via the javaField

Kotlin -> Java reflection mapping

ee59510

Implemented: - KProperty<*>.javaGetter - KMutableProperty<*>.javaSetter - KFunction<*>.javaMethod - KCallable<*>.isAccessible

Test for private fields access: comparing the behaviour of reflect.li…

497d751

…te and kotlin.reflect on the expected use-case from "incorrectNumberOfArguments" test

Moved unsupported tests to the separate directory

1d9c683

Lazy initialization for callable descriptors

c031353

Support overridden properties

54c7e08

More tests for KCallable<*>.call

73b6f47

More tests for top-level and extension functions

f54ac16

Fixed visibility modifiers of some declarations to be internal

d0b9bf5

qwwdfsad reviewed Aug 9, 2022

View reviewed changes

src/main/java/kotlinx/reflect/lite/impl/KClasses.kt Outdated Show resolved Hide resolved

mvicsokolova added 4 commits August 10, 2022 11:58

Fixed bug in KClass<T>.primaryConstructor and added a test

e3aac87

Added JvmClassMapping class file with API for mapping Java to Kotlin …

65677da

…classes: `Class<T>.kotlin` and `KClass<T>.java` API

Use Class<T>.kotlin and Class<T>.kotlinPackage API in tests

eacc252

Added tests for KCallable<*>.callSuspend

da0fd7a

mvicsokolova force-pushed the mvicsokolova/dev branch from 84ba630 to da0fd7a Compare August 11, 2022 15:49

mvicsokolova and others added 11 commits August 12, 2022 14:00

Fix toKotlinType() for the case of star type projection

4602515

Add descriptors for Java classes

88d3b03

Add thisAsReceiverParameter property to ClassDescriptor

be83ff1

Some fixes in tests

3e42d57

Implementation of Java class descriptor should be completed

48f54b1

Lazy initialization of ClassDescriptor properties

d355b95

Implementation of Java descriptors

63a3760

Update KClass tests

0ac4748

Make private whatever can be private

6cfff5e

Better exception message instead of plain TODO

551c3d9

Codestyle changes

6d8b4e5

qwwdfsad mentioned this pull request Aug 30, 2022

Improve kotlinx.reflect.lite and rewrite it to use kotlinx.metadata.jvm under the hood #12

Closed

qwwdfsad and others added 8 commits August 30, 2022 12:54

Revise public modifiers in root package

9b34b13

Move JvmClassMapping to its own public package kotlinx.reflect.lite.jvm

13bff23

Move ReflectJvmMapping to its own public package kotlinx.reflect.lite…

843debe

….jvm

Cleanup build infra

c127e58

Move corresponding declarations to full package, add -no-reflect

598dae3

Documentation for KPackage

27b7642

ReflectJvmMapping: fixed KPackage creation + public modifiers

989f2a4

Update Copyright notes

6670c25

qwwdfsad self-requested a review August 30, 2022 17:19

qwwdfsad approved these changes Aug 30, 2022

View reviewed changes

mvicsokolova merged commit 23297f1 into dev Aug 30, 2022

Updating reflect.lite to the new kotlinx.metadata.jvm #19

Updating reflect.lite to the new kotlinx.metadata.jvm #19

Uh oh!

Conversation

mvicsokolova commented Jan 13, 2022

Uh oh!

dkhalanskyjb Jan 14, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dkhalanskyjb commented Jan 14, 2022

Uh oh!

dkhalanskyjb commented Jan 17, 2022

Uh oh!

Uh oh!

dkhalanskyjb Feb 14, 2022

Choose a reason for hiding this comment

Uh oh!

mvicsokolova Feb 15, 2022

Choose a reason for hiding this comment

Uh oh!

dkhalanskyjb Feb 14, 2022

Choose a reason for hiding this comment

Uh oh!

mvicsokolova Jul 18, 2022

Choose a reason for hiding this comment

Uh oh!

dkhalanskyjb Jul 19, 2022

Choose a reason for hiding this comment

Uh oh!

dkhalanskyjb Jul 28, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

qwwdfsad left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants