Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating reflect.lite to the new kotlinx.metadata.jvm #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating reflect.lite to the new kotlinx.metadata.jvm #19
Changes from all commits
8e3daed
6c0aa0d
8c02d69
315d2a0
c42939c
04d7b75
1184613
3f84f57
7876740
5dc9c07
a5276f0
d02ab87
bb632b9
8fe9422
50f0005
0864056
3e6788f
d9a8667
ee59510
497d751
1d9c683
c031353
54c7e08
73b6f47
f54ac16
9bd29fe
2bfa10f
9fd5a56
de05b75
90a9918
3c0365d
13627f9
f067ce4
910a0c9
414a973
4c35c36
83284b8
0c8c97e
29ff391
827bfdc
30458e9
7fa40f2
8fededb
542ea8b
83726b2
e42791b
d261679
02659c1
61a186f
c87de55
d0b9bf5
e3aac87
65677da
eacc252
da0fd7a
4602515
88d3b03
be83ff1
3e42d57
48f54b1
d355b95
63a3760
0ac4748
6cfff5e
551c3d9
6d8b4e5
9b34b13
13bff23
843debe
c127e58
598dae3
27b7642
989f2a4
6670c25
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it turns out that
ReflectProperties.java
is not needed (or can be easily rewritten in Kotlin), this won't be needed any longer, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use the
-no-reflect
flag here to make sure we don't rely onkotlin.reflect
anywhere. For now, I only seeimport kotlin.reflect
inunusedTestData
andtestData
(the latter should be investigated if it turns out these tests were not left intestData
by mistake).