-
Notifications
You must be signed in to change notification settings - Fork 365
Update PatternFly to v3.31.1 #2989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@skateman 'himdel, epwinchell' is an invalid assignee, ignoring... |
b9699cd
to
5f26b2b
Compare
Marked it WIP until patternfly/angular-patternfly#689 gets merged |
5f26b2b
to
3ac1556
Compare
Checked commit skateman@3ac1556 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
LGTM, not seeing any UI breakage (notification thing has different spacing in places, but otherwise..) (Except for the notification icon issue, @skateman is working on.) |
@skateman I see the same bug. It's affecting PDF downloads on GTL and dashboard widgets, as well. |
Fixed by #3041, thanks :) |
@skateman , @epwinchell Do we have a fix for the notification icon? Also... all our selectpickers now look disabled - patternfly/patternfly#888 |
@miq-bot add_label fine/no, gaprindashvili/no
@himdel and @epwinchell please test this 😉 🎉