Skip to content

Conversation

skateman
Copy link
Member

@skateman skateman commented Dec 8, 2017

@miq-bot add_label fine/no, gaprindashvili/no

@himdel and @epwinchell please test this 😉 🎉

@miq-bot
Copy link
Member

miq-bot commented Dec 8, 2017

@skateman 'himdel, epwinchell' is an invalid assignee, ignoring...

@skateman skateman changed the title Update PatternFly to v3.31.1 [WIP] Update PatternFly to v3.31.1 Dec 8, 2017
@skateman
Copy link
Member Author

skateman commented Dec 8, 2017

Marked it WIP until patternfly/angular-patternfly#689 gets merged

@miq-bot miq-bot added the wip label Dec 8, 2017
@epwinchell
Copy link
Contributor

@skateman @himdel Everything looks A-ok.

@miq-bot
Copy link
Member

miq-bot commented Dec 11, 2017

Checked commit skateman@3ac1556 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@himdel
Copy link
Contributor

himdel commented Dec 11, 2017

I, [2017-12-11T15:24:41.945607 #31727]  INFO -- :   Rendered /home/himdel/manageiq-ui-classic/app/views/layouts/_doctype.html.haml (0.8ms)
DEPRECATION WARNING: Passing a percentage as the alpha value to rgba() will be
interpreted differently in future versions of Sass. For now, use 0.125 instead.

DEPRECATION WARNING: Passing a percentage as the alpha value to rgba() will be
interpreted differently in future versions of Sass. For now, use 0.075 instead.

DEPRECATION WARNING: Passing a percentage as the alpha value to rgba() will be
interpreted differently in future versions of Sass. For now, use 0.075 instead.

DEPRECATION WARNING: Passing a percentage as the alpha value to rgba() will be
interpreted differently in future versions of Sass. For now, use 0.075 instead.

DEPRECATION WARNING: Passing a percentage as the alpha value to rgba() will be
interpreted differently in future versions of Sass. For now, use 0.5 instead.

DEPRECATION WARNING: Passing a percentage as the alpha value to rgba() will be
interpreted differently in future versions of Sass. For now, use 0.5 instead.

DEPRECATION WARNING: Passing a percentage as the alpha value to rgba() will be
interpreted differently in future versions of Sass. For now, use 0.175 instead.

DEPRECATION WARNING: Passing a percentage as the alpha value to rgba() will be
interpreted differently in future versions of Sass. For now, use 0.175 instead.

DEPRECATION WARNING: Passing a percentage as the alpha value to rgba() will be
interpreted differently in future versions of Sass. For now, use 0.075 instead.

DEPRECATION WARNING: Passing a percentage as the alpha value to rgba() will be
interpreted differently in future versions of Sass. For now, use 0.5 instead.

DEPRECATION WARNING: Passing a percentage as the alpha value to rgba() will be
interpreted differently in future versions of Sass. For now, use 0.5 instead.

DEPRECATION WARNING: Passing a percentage as the alpha value to rgba() will be
interpreted differently in future versions of Sass. For now, use 0.175 instead.

DEPRECATION WARNING: Passing a percentage as the alpha value to rgba() will be
interpreted differently in future versions of Sass. For now, use 0.045 instead.

I, [2017-12-11T15:24:54.566598 #31727]  INFO -- :   Rendered /home/himdel/manageiq-ui-classic/app/views/stylesheets/_template50.html.haml (1.0ms)

@skateman skateman changed the title [WIP] Update PatternFly to v3.31.1 Update PatternFly to v3.31.1 Dec 11, 2017
@skateman
Copy link
Member Author

@himdel patternfly/patternfly#852

@himdel
Copy link
Contributor

himdel commented Dec 11, 2017

LGTM, not seeing any UI breakage (notification thing has different spacing in places, but otherwise..)

(Except for the notification icon issue, @skateman is working on.)

@himdel himdel self-assigned this Dec 11, 2017
@himdel himdel removed the wip label Dec 11, 2017
@himdel himdel merged commit ad9e370 into ManageIQ:master Dec 11, 2017
@himdel himdel added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 11, 2017
@skateman skateman deleted the patternfly-update branch December 11, 2017 15:56
@hstastna
Copy link

When I go to Compute > Clouds > Providers and choose my AWS provider and there, in summary page I click on Storage Managers (under Relationships), and then if I try to Download as PDF, I get this:
aws

Note: Downloading as TXT or CSV works.

@epwinchell
Copy link
Contributor

epwinchell commented Dec 12, 2017

@skateman I see the same bug. It's affecting PDF downloads on GTL and dashboard widgets, as well.

@himdel
Copy link
Contributor

himdel commented Dec 12, 2017

Fixed by #3041, thanks :)

@himdel
Copy link
Contributor

himdel commented Dec 15, 2017

@skateman , @epwinchell Do we have a fix for the notification icon?

Also... all our selectpickers now look disabled - patternfly/patternfly#888
@epwinchell Is that something we want to override back or do you think that's ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants