Clean up duplicate pagination styling #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label refactoring, gaprindashvili/no |
|
@epwinchell Cannot apply the following label because they are not recognized: gaprindashvili/no |
epwinchell
changed the title
|
Checked commit https://github.com/epwinchell/ui-components/commit/d89fc68f9c74ced272bb76a13689bd73e572aa8c with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
LGTM, not seeing any UI breakage 👍 Not merging yet, as this is (The moment we merge this, we'll need to start doing branches if we want to do any more g/yes after.) |
|
Well, there is a branch now .. 1.0.* will be from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove pagination styling that is now available in the update PatternFly to v3.31.1, here: ManageIQ/manageiq-ui-classic#2989