Splitting dist/ from git

[himdel]

There's been a few discussion around the topic of not having dist/ in git, to prevent useless merge conflicts, etc.

Seems like there's 2 options - separate repo for the built package, or gitignore dist/ and git add --force the files. Either relies on travis updating dist/ when doing a successful master build.

Creating the issue so we can have 1 place for the discussion on how to do that...

Cc @mtho11 , @martinpovolny , @karelhala , @skateman

[skateman]

I tried the git add --force and it simply overwrites the .gitignore so after the file is force-added into the repo, the line in .gitignore gets ignored ... i.e. it's useless.

IMHO both solutions are terrible, binaries should not be present in any git repository. The best would be to drop bower and push to npm using travis, but I know I want too much 😜

[skateman]

However, I have a completely primitive (and maybe the same terrible) idea: let's drop the binaries and explicitly call npm install and node_modules/webpack/bin/webpack.js -p from the bin/setup available in manageiq-ui-classic. Then we can clean it up when we introduce webpacker.

[himdel]

Ok, I guess that settles it :) We need a separate repo if we want to support bower.

Or we can drop bower support, and then we can just npm publish the binaries, yup. (Although that means we can no longer use the master branch as a dependency.)

[skateman]

Why not? Can't we create a dummy auto-incremented -dev version after each merge into master? Let's call it unstable branch, or the sid 😉

[himdel]

That works too :)

[skateman]

Actually, we can do this with bower too, right?

[himdel]

Yup, that's true, bower just needs a tag, doesn't strictly need a branch or anything else.

[skateman]

So we can create a dev tag, a travis deploy hook with a script and an access token set as a secret ENV var in Travis for miq-bot from @Fryguy.

[Fryguy]

drop bower support

👍

[Fryguy]

What exactly is the issue you are trying to solve though? Is it just having a place to publish the builds that's not git? A repo feels like overkill...what about upload to manageiq.org or some other download location? I believe that could even be done as part of a travis deploy step on merge to master if you need the latest and greatest somewhere.

npm publish the binaries

feels like the best approach, to me.

[himdel]

@Fryguy it needs to be on github if we're to support bower. But we can probably drop it now that ui-classic can use npm packages (just need to finish the PRs to appliance, docker, etc..)

But the issue we're trying to solve is that by having the generated dist/ files in git, you get a conflict on every PR once any other PR is merged.

[karelhala]

I like @skateman's idea of publishing dist under some dummy tag or branch.

[skateman]

@karelhala working on it