Automated build of binaries from master to a dev tag using Travis #83

skateman · 2017-07-12T11:00:04Z

It resolves #81, but still needs an username:token pair for miq-bot to set as GITHUB_AUTH in Travis' secret environment variables. Basically something similar (or even the same) as we have for font-fabulous. @Fryguy ??

Fryguy · 2017-07-12T18:18:40Z

still needs an username:token pair for miq-bot to set as GITHUB_AUTH in Travis' secret environment variables

not a problem, we can do that when ready.

Fryguy · 2017-07-12T18:31:23Z

@skateman I commented over on #81 (comment) to keep the discussion in one place.

himdel · 2017-07-13T12:06:50Z

Once ManageIQ/manageiq-ui-classic#1682 is green, I'll run the script manually to update the bower-dev branch, and merge that PR. Then, we can merge this, and once GITHUB_AUTH is there, it should update the branch automagically :).

Fryguy · 2017-07-13T13:51:37Z

Oh I can make the GITHUB_AUTH now, I just have to remember how 😂

himdel · 2017-07-13T13:53:18Z

@skateman You'll also want to remove

!dist/js/ui-components.js.map
!dist/css/ui-components.css.map

from .gitignore..

himdel · 2017-07-13T13:56:55Z

Ran the script manually, pushed to the bower-dev branch, restarting travis on ManageIQ/manageiq-ui-classic#1682 ..

himdel · 2017-07-13T14:03:17Z

@skateman We probably also want to add

branches:
  except:
  - bower-dev

to .travis.yml, so that Travis stops trying to fail running tests on that branch :)

skateman · 2017-07-13T14:04:16Z

@himdel if Travis is configured to build only when a .travis.yml is present, then you won't need that.

himdel · 2017-07-13T14:07:13Z

@himdel if Travis is configured to build only when a .travis.yml is present, then you won't need that.

Ok.. @Fryguy can you do that please? Or should we just add it to .travis.yml? :)

skateman · 2017-07-13T14:13:45Z

Well, then we need the .travis.yml into the bower-dev branch, so easier to flip the switch 😉

Fryguy · 2017-07-13T15:11:56Z

ok GITHUB_AUTH is created.

Fryguy · 2017-07-13T15:12:42Z

if Travis is configured to build only when a .travis.yml is present

That is the current configuration, however you may want it anyway if you decide to create things like dev branches or whatever.

himdel · 2017-07-13T15:29:26Z

Ok, merged the ui-classic PR, seems like the branch is working :).

So.. merging, and we should watch travis to see if it works there as well..

Fryguy · 2017-07-13T15:42:25Z

@skateman @himdel, we may want a README.md on that new branch to describe its purpose and how it works and whatnot.

himdel · 2017-07-13T15:43:21Z

@Fryguy Agreed, will do :)

himdel · 2017-07-13T15:52:48Z

Added a simple README - https://github.com/ManageIQ/ui-components/tree/bower-dev

himdel · 2017-07-13T15:55:37Z

@Fryguy I'm pretty sure Travis is attempting to run on all the branches now, regardless of .travis.yml presence.

https://travis-ci.org/ManageIQ/ui-components/builds/253175668#L6

himdel · 2017-07-13T15:59:30Z

@skateman So.. not sure if it works .. https://travis-ci.org/ManageIQ/ui-components/builds/253258727#L1346 would seem to indicate that yes, it ran perfectly... But I'm not seeing the commit appearing on that branch.

Not sure if we can drop that &> /dev/null temporarily without exposing the auth credential....

skateman · 2017-07-13T16:04:28Z

@himdel we can't 😉

himdel · 2017-07-13T16:18:17Z

Debugging by temporarily adding a git status before that commit .. and a git log -p -1 after.. 8a852d5

(The idea being that nothing added to commit but untracked files present sounds wrong.)

Travis: https://travis-ci.org/ManageIQ/ui-components/builds/253278676

himdel · 2017-07-13T16:24:47Z

+git add -f dist/css/ui-components.css dist/css/ui-components.css.map
+git add -f dist/js/ui-components.js dist/js/ui-components.js.map
+git add -f bower.json
+git status
On branch bower-dev
Your branch is up-to-date with 'upstream/bower-dev'.
Untracked files:
  (use "git add <file>..." to include in what will be committed)
	coverage/
	dist/tmp/
	node_modules/
nothing added to commit but untracked files present (use "git add" to track)
+git commit -m 'Automated build from 8a852d52855036690f5928303c28e2a33d479748'
On branch bower-dev
Your branch is up-to-date with 'upstream/bower-dev'.
Untracked files:
	coverage/
	dist/tmp/
	node_modules/
nothing added to commit but untracked files present
+git log -p -1
commit 8890257d674dba48715eee743afed899be899390
Author: Martin Hradil <[email protected]>
Date:   Thu Jul 13 15:50:22 2017 +0000
    add README.md

So, yup, the commit didn't happen, but there's probably nothing wrong. Turns out, you need actual code changes for the compiled code to change :D.

Trying that once I find a mergable PR...

himdel · 2017-07-13T16:37:08Z

Merged #86 ...

Travis: https://travis-ci.org/ManageIQ/ui-components/builds/253285727

himdel · 2017-07-13T16:41:37Z

aaah.. found the problem...

+mv -f tmp dist
...
Untracked files:
        ...
	dist/tmp/

mv tmp dist doesn't do the right thing if dist/ already exists..

himdel · 2017-07-13T16:58:08Z

After the fix... https://travis-ci.org/ManageIQ/ui-components/builds/253292826

himdel · 2017-07-13T17:03:29Z

+git add -f dist/css/ui-components.css dist/css/ui-components.css.map
+git add -f dist/js/ui-components.js dist/js/ui-components.js.map
+git add -f bower.json
+git status
On branch bower-dev
Your branch is up-to-date with 'upstream/bower-dev'.
Changes to be committed:
  (use "git reset HEAD <file>..." to unstage)
	modified:   dist/js/ui-components.js.map
Untracked files:
  (use "git add <file>..." to include in what will be committed)
	coverage/
	dist/assets/
	dist/css/demo-app.css
	dist/css/demo-app.css.map
	dist/css/vendor.css
	dist/data/
	dist/index.html
	dist/js/demo-app.js
	dist/js/demo-app.js.map
	dist/js/vendor.js
	node_modules/
+git commit -m 'Automated build from a2184056e66ca016a3d280c956a5693f2ba3e71d'
[bower-dev 6c4bad1] Automated build from a2184056e66ca016a3d280c956a5693f2ba3e71d
 1 file changed, 1 insertion(+), 1 deletion(-)
+git log -p -1
commit 6c4bad14f7235bc2c5d3c2ecb23e4e2edd1882a8
Author: Travis CI User <[email protected]>
Date:   Thu Jul 13 17:00:13 2017 +0000
    Automated build from a2184056e66ca016a3d280c956a5693f2ba3e71d

Sounds better, the commit was actually created now :).

...after the diff...
+set +x
git push origin HEAD:bower-dev
Done. Your build exited with 0.

Which would sound perfect, except for the fact I can't see it in https://github.com/ManageIQ/ui-components/commits/bower-dev :(

himdel · 2017-07-13T17:07:02Z

Any chance you need to push HEAD:bower-dev instead of just bower-dev? Or something?

Either way, going for today, for now as a workardound, all the mergers can run the script manually to update the branch.. but we'll need to figure this out :)

Fryguy · 2017-07-13T18:39:09Z

I don't think you need the -f part of the git push -f. You are doing a normal commit, not force pushing. In fact, the -f could cause other problems if we protect the branch.

Fryguy · 2017-07-13T18:40:21Z

The idea being that nothing added to commit but untracked files present sounds wrong.

This could definitely happen if the changes in the PR are things like README changes that would not change the dist at all. I think the script needs to handle this case.

himdel · 2017-07-14T09:56:10Z

Removing that -f .. https://travis-ci.org/ManageIQ/ui-components/builds/253542693

I think the script needs to handle this case.

Looks like it alrady handles that case :D.

himdel · 2017-07-14T10:20:59Z

So.. I've updated the script to output $? after commit and push, just to verify the push isn't succeeding somewhere.. but I'm pretty much stumped. As in, can't continue without seeing the actual error message from git push.. @Fryguy I think you'll have to look into this, sorry :).

The script works, both on travis and locally, if I run the same with --dry-run and my credentials, the push pretends to succeed, so .. possibly a wrong GITHUB_AUTH value, or wrong syntax, or a leading/trailing space in the value or something like that...

Fryguy mentioned this pull request Jul 12, 2017

Splitting dist/ from git #81

Closed

skateman force-pushed the bower-dev-build branch from 1fd660f to ab8483d Compare July 13, 2017 11:23

skateman mentioned this pull request Jul 13, 2017

Load ui-components from its bower-dev branch ManageIQ/manageiq-ui-classic#1682

Merged

Automated build of binaries from master to a dev tag using Travis

6eac076

skateman force-pushed the bower-dev-build branch from ab8483d to 6eac076 Compare July 13, 2017 13:59

himdel mentioned this pull request Jul 13, 2017

Toolbar color #85

Merged

himdel mentioned this pull request Jul 13, 2017

Create Dialog component #82

Merged

himdel merged commit d6060d3 into ManageIQ:master Jul 13, 2017

himdel self-assigned this Jul 13, 2017

himdel added the build label Jul 13, 2017

skateman deleted the bower-dev-build branch July 13, 2017 16:11

himdel mentioned this pull request Jul 13, 2017

Add missing semicolon in the fonticon picker #86

Merged

himdel mentioned this pull request Jul 13, 2017

Fix bower deployment if the dist folder already exists #87

Merged

himdel mentioned this pull request Jul 14, 2017

Clean build process so there are no more errors with missing __ function #77

Merged

Fryguy mentioned this pull request Jul 17, 2017

bower-dev builds not working #88

Closed

Automated build of binaries from master to a dev tag using Travis #83

Automated build of binaries from master to a dev tag using Travis #83

Uh oh!

Conversation

skateman commented Jul 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fryguy commented Jul 12, 2017

Uh oh!

Fryguy commented Jul 12, 2017

Uh oh!

himdel commented Jul 13, 2017

Uh oh!

Fryguy commented Jul 13, 2017

Uh oh!

himdel commented Jul 13, 2017

Uh oh!

himdel commented Jul 13, 2017

Uh oh!

himdel commented Jul 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skateman commented Jul 13, 2017

Uh oh!

himdel commented Jul 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skateman commented Jul 13, 2017

Uh oh!

Fryguy commented Jul 13, 2017

Uh oh!

Fryguy commented Jul 13, 2017

Uh oh!

himdel commented Jul 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fryguy commented Jul 13, 2017

Uh oh!

himdel commented Jul 13, 2017

Uh oh!

himdel commented Jul 13, 2017

Uh oh!

himdel commented Jul 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

himdel commented Jul 13, 2017

Uh oh!

skateman commented Jul 13, 2017

Uh oh!

himdel commented Jul 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

himdel commented Jul 13, 2017

Uh oh!

himdel commented Jul 13, 2017

Uh oh!

himdel commented Jul 13, 2017

Uh oh!

himdel commented Jul 13, 2017

Uh oh!

himdel commented Jul 13, 2017

Uh oh!

himdel commented Jul 13, 2017

Uh oh!

Fryguy commented Jul 13, 2017

Uh oh!

Fryguy commented Jul 13, 2017

Uh oh!

himdel commented Jul 14, 2017

Uh oh!

himdel commented Jul 14, 2017

Uh oh!

Uh oh!

skateman commented Jul 12, 2017 •

edited

Loading

himdel commented Jul 13, 2017 •

edited

Loading

himdel commented Jul 13, 2017 •

edited

Loading

himdel commented Jul 13, 2017 •

edited

Loading

himdel commented Jul 13, 2017 •

edited

Loading

himdel commented Jul 13, 2017 •

edited

Loading