Toolbar color #85
Merged
Toolbar color #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How it behaves if there is no color specified? |
|
@skateman the first |
|
LGTM, will merge after #83 so that we can stop manually rebuilding |
|
Pivotal story: https://www.pivotaltracker.com/n/projects/1613907 |
|
#83 merged. Please, rebase and we can merge this one. Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #84
As requested toolbar items should be colored based on JSON property
colorfor each item.Buttons, dropdown lists and dropdown items are colored by this property. Separators are not colored.
Color property can be hexa number with hash in it and text corresponding to such color.
Before
After
Note: added another button with
Powertext to test data.