Skip to content

Conversation

skateman
Copy link
Member

No description provided.

@himdel
Copy link
Contributor

himdel commented Jul 13, 2017

.. the idea being that we drop any old dist/ before replacing it completely with the freshly built one.

And mv -f tmp dist will always rename, not move to dist/tmp as it did when dist already existed.

(Fixes a bug introduced in #83.)

Waiting for green 👍

@himdel himdel self-assigned this Jul 13, 2017
@himdel himdel merged commit a218405 into ManageIQ:master Jul 13, 2017
@skateman skateman deleted the fix-deploy branch July 13, 2017 16:59
git remote add upstream https://github.com/ManageIQ/ui-components.git
git fetch upstream
git checkout bower-dev
rm -rf dist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will delete also any ancillary files like the README and LICENSE, which might have side effects?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README and LICENSE are not in the dist folder

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see...they are at the root of the repo. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants