-
-
Notifications
You must be signed in to change notification settings - Fork 2
Migrate from RSA to EC (Elliptic Curve) Algorithm for OpenSSL Usage in PHP #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… update RSA classes to default to EC Co-authored-by: MayMeow <[email protected]>
Co-authored-by: MayMeow <[email protected]>
Co-authored-by: MayMeow <[email protected]>
…ec' key for improved structure
…gnment of configArgs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
@@ -28,6 +30,10 @@ public function __construct() | |||
*/ | |||
public function generateKeys(string $passphrase, ?array $configArgs = null, string $salt = 'salt'): RSAParameters | |||
{ | |||
if ($configArgs !== null) { | |||
$this->config = $configArgs; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace instead of merge configs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current code already replaces configs (line 34: $this->config = $configArgs;
) instead of merging them. This was changed in commit de85b51. Is this the desired behavior or did you want me to change it to merge instead?
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR implements a comprehensive migration from RSA to Elliptic Curve (EC) cryptography as the default for better performance and security, while maintaining full backward compatibility.
🚀 Key Changes
Core Migration
New Classes Added
ECParameters
- Dedicated EC key generation and managementECCryptoServiceProvider
- EC-specific crypto operations with proper limitationsSmart Compatibility Handling
🔧 Usage Examples
Default EC Signing (New Behavior)
Explicit RSA for Encryption (Backward Compatibility)
Dedicated EC Classes
📊 Performance Benefits
If you only use signing/verification: No changes needed - automatically uses faster EC keys.
If you use encryption/decryption:
🧪 Testing
📚 Documentation
🔒 Security & Compatibility Notes
Fixes #27.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
api.github.com
/usr/bin/php8.3 -n -c /tmp/P3dYRm /usr/bin/composer install
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.