Skip to content

Conversation

amitz-nv
Copy link
Collaborator

@amitz-nv amitz-nv commented Jun 18, 2025

Description

  1. The torch LoRA TP tests in unittest/llmapi/test_llm_multi_gpu_pytorch.py were not running so far on CI because they use just 2 GPUs, while the DGX has 4, and the pytest command line filtered only the tests marked with @pytest.mark.gpu4, so I fixed the pytest command line to also run tests marked with @pytest.mark.gpu2.
  2. Fixed ModelConfig.get_bindings_model_config method calculations to be like gptJsonConfig.cpp::createModelConfig, as stated in get_bindings_model_config docstring.

Test Coverage

Torch LoRA TP>1 tests:

  1. tests/unittest/llmapi/test_llm_multi_gpu_pytorch.py::test_llama_v2_13b_lora_tp2
  2. tests/unittest/llmapi/test_llm_multi_gpu_pytorch.py::test_llama_7b_multi_lora_tp2

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@amitz-nv amitz-nv requested a review from a team as a code owner June 18, 2025 16:08
@amitz-nv amitz-nv requested review from lfr-0531 and liji-nv June 18, 2025 16:08
@amitz-nv amitz-nv changed the title [[TRTLLM-5825](https://jirasw.nvidia.com/browse/TRTLLM-5825)][fix] Fix torch LoRA TP [TRTLLM-5825][fix] Fix torch LoRA TP Jun 18, 2025
@amitz-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9405 [ run ] triggered by Bot

@amitz-nv amitz-nv requested a review from shaharmor98 June 18, 2025 16:25
@tensorrt-cicd
Copy link
Collaborator

PR_Github #9405 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6901 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

Copy link
Collaborator

@shaharmor98 shaharmor98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@shaharmor98 shaharmor98 merged commit 1753202 into NVIDIA:main Jun 19, 2025
4 checks passed
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 9, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants