Skip to content

[TRTLLM-5825][fix] Fix torch LoRA TP #5338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025
Merged

[TRTLLM-5825][fix] Fix torch LoRA TP #5338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b41098a
Fixed ModelConfig.get_bindings_model_config to calculate fields like …
amitz-nv Jun 18, 2025
7b2d3de
Configure pytorch LoRA TP tests to run on DGX
amitz-nv Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tensorrt_llm/_torch/model_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,14 +282,15 @@ def get_bindings_model_config(self) -> "ModelConfigCpp":

num_heads = self.pretrained_config.num_attention_heads // (
self.mapping.tp_size * self.mapping.cp_size)
hidden_size = self.pretrained_config.hidden_size // self.mapping.tp_size

model_config_cpp = ModelConfigCpp(
vocab_size=self.pretrained_config.vocab_size,
num_layers=self.pretrained_config.num_hidden_layers,
num_attention_layers=self.pretrained_config.num_hidden_layers,
num_rnn_layers=0,
num_heads=num_heads,
hidden_size=self.pretrained_config.hidden_size,
hidden_size=hidden_size,
data_type=torch_dtype_to_binding(
self.pretrained_config.torch_dtype))

Expand Down Expand Up @@ -317,7 +318,7 @@ def get_bindings_model_config(self) -> "ModelConfigCpp":
if "head_size" in self.pretrained_config:
head_size = self.pretrained_config.head_size
else:
head_size = self.pretrained_config.hidden_size // num_heads
head_size = hidden_size // num_heads

model_config_cpp.mlp_hidden_size = mlp_hidden_size
model_config_cpp.size_per_head = head_size
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_lists/test-db/l0_dgx_h100.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ l0_dgx_h100:
# ------------- PyTorch tests ---------------
- unittest/_torch/multi_gpu
- unittest/_torch/auto_deploy/unit/multigpu
- unittest/llmapi/test_llm_multi_gpu_pytorch.py -m "gpu4"
- unittest/llmapi/test_llm_multi_gpu_pytorch.py -m "gpu4 or gpu2"
- accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_bfloat16_4gpus[tp4-attn_backend=TRTLLM-torch_compile=False]
- accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_bfloat16_4gpus[tp4-attn_backend=TRTLLM-torch_compile=True]
- accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_bfloat16_4gpus[tp2pp2-attn_backend=TRTLLM-torch_compile=False]
Expand Down