Skip to content

Conversation

achartier
Copy link
Collaborator

@achartier achartier commented Jul 10, 2025

PR title

feat: Add support for Triton request cancellation

Description

Handle request cancellation in Triton torch backend:

  • Add handling for stop signal
  • Add cancellation thread checking for cancellation status every ms

Add llmapi_client script to test the feature

Extend existing test to check cancellation works

Test Coverage

test_llmapi_backend

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@achartier achartier force-pushed the triton-cancel branch 2 times, most recently from 07f48ba to b68d79d Compare July 11, 2025 03:33
@achartier achartier marked this pull request as ready for review July 11, 2025 03:33
@achartier
Copy link
Collaborator Author

/bot run --stage-list "A30-Triton-Post-Merge-1, A30-Triton-Post-Merge-2, B200_PCIe-Triton-Post-Merge-1, A100X-Triton-Post-Merge-1, A100X-Triton-Post-Merge-2"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11593 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11593 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8587 (Partly Tested) completed with status: 'SUCCESS'

Signed-off-by: Aurelien Chartier <[email protected]>
Signed-off-by: Aurelien Chartier <[email protected]>
Signed-off-by: Aurelien Chartier <[email protected]>
Signed-off-by: Aurelien Chartier <[email protected]>
Signed-off-by: Aurelien Chartier <[email protected]>
@achartier
Copy link
Collaborator Author

/bot run --stage-list "A30-Triton-Post-Merge-1, A30-Triton-Post-Merge-2, B200_PCIe-Triton-Post-Merge-1, A100X-Triton-Post-Merge-1, A100X-Triton-Post-Merge-2"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11667 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11667 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8639 (Partly Tested) completed with status: 'SUCCESS'

@achartier
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11695 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11695 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8657 completed with status: 'SUCCESS'

@pcastonguay
Copy link
Collaborator

@SimengLiu-nv could you also have a look please? Thanks.

@pcastonguay pcastonguay requested a review from SimengLiu-nv July 14, 2025 16:01
Copy link
Collaborator

@SimengLiu-nv SimengLiu-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good to me.
I hope more testing can be added, for example: Send stop to a request id that doesn't exist. Or already completed.

@pcastonguay pcastonguay self-requested a review July 16, 2025 00:52
@pcastonguay pcastonguay merged commit 6a47cac into NVIDIA:main Jul 16, 2025
3 checks passed
@achartier achartier deleted the triton-cancel branch July 16, 2025 02:19
evezhier pushed a commit to evezhier/TensorRT-LLM that referenced this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants