[None][chore] Add tests for non-existent and completed request cancellation #6840
Conversation
Signed-off-by: Aurelien Chartier <[email protected]>
📝 WalkthroughWalkthroughAdds a new gRPC cancellation test script and executes it from an existing Triton LLM integration test; the integration invocation runs the script but does not assert on its output. Changes
Sequence Diagram(s)sequenceDiagram
participant Caller as test_llmapi_cancel.py
participant Triton as Triton Server (gRPC)
Caller->>Triton: Stop(request_id=nonexistent)
Triton-->>Caller: InferenceServerException (CANCELLED)
Caller->>Triton: Infer(request_id=1, streaming=false)
Triton-->>Caller: Result (via callback)
Caller->>Triton: Cancel(request_id=1)
Caller->>Triton: Stop(request_id=1)
Triton-->>Caller: InferenceServerException (CANCELLED)
Caller->>Triton: Infer(request_id=2, streaming=false)
Triton-->>Caller: Result (via callback)
Caller->>Caller: Compare text_output(req1) == text_output(req2)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~15 minutes Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
/bot run |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (2)
triton_backend/tools/tests/test_llmapi_cancel.py (2)
80-82: Optional: clarify or drop cancel() after completionCalling
infer_response.cancel()after the request has completed is a no-op in many clients and may be confusing. Since the next step explicitly tests server-side stop on a completed request, consider removing this call or add a short comment that it’s intentionally verifying cancel-on-complete is benign.- # Cancel request after it is completed - infer_response.cancel() + # Intentional no-op to validate cancelling a completed request is benign. + # infer_response.cancel()
110-112: Determinism note: ensure generation settings are deterministic before asserting equalityThe equality assertion assumes deterministic generation. Ensure
_prepare_inputssets temperature to 0 (or equivalent) and fixes seeds. If not guaranteed, this assertion can be flaky.If determinism is not guaranteed, either:
- enforce deterministic settings via
_prepare_inputs(temperature=0, top_p=0, seed), or- relax the check to validate non-empty output and server liveness instead of strict equality.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
tests/integration/defs/triton_server/test_triton_llm.py(1 hunks)triton_backend/tools/tests/test_llmapi_cancel.py(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.py
📄 CodeRabbit Inference Engine (CODING_GUIDELINES.md)
**/*.py: Python code must target Python 3.8+
Python indentation: 4 spaces, no tabs
Maintain module namespace in imports (from package.subpackage import foo; then use foo.SomeClass())
Python file names use snake_case
Python class names use PascalCase
Python functions/methods and local variables use snake_case; variables starting with a number get k_ prefix (e.g., k_99th_percentile)
Global variables use G_ prefixed UPPER_SNAKE_CASE (e.g., G_MY_GLOBAL)
Constants use UPPER_SNAKE_CASE in Python
Avoid shadowing variables from outer scopes in Python
Initialize all externally visible members of a Python class in init
Prefer docstrings for interfaces used outside a file; comments for local code
Use Google-style docstrings for classes and functions (Sphinx-parsable)
Document attributes/variables inline with short docstrings
Avoid reflection when simple alternatives exist (e.g., prefer explicit parameters over dict(**locals()))
In try/except, catch the narrowest exceptions possible
For duck-typing with try/except, keep try body minimal and put logic in else
Files:
tests/integration/defs/triton_server/test_triton_llm.pytriton_backend/tools/tests/test_llmapi_cancel.py
**/*.{cpp,cxx,cc,cu,h,hpp,hxx,hh,cuh,py}
📄 CodeRabbit Inference Engine (CODING_GUIDELINES.md)
Prepend NVIDIA copyright header (current year) to all source files
Files:
tests/integration/defs/triton_server/test_triton_llm.pytriton_backend/tools/tests/test_llmapi_cancel.py
🧠 Learnings (1)
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
Applied to files:
tests/integration/defs/triton_server/test_triton_llm.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (1)
triton_backend/tools/tests/test_llmapi_cancel.py (1)
45-46: Static request_id is appropriate in this standalone testSince this script is guarded by
if __name__ == "__main__":and run as a self-contained integration test (with a fresh Triton server per invocation), using a hard-codedrequest_id = 1(andrequest_id + 1for the second call) guarantees deterministic behavior without risk of cross-test collisions. Introducing randomness would make reproducing failures harder.
|
PR_Github #15019 [ run ] triggered by Bot |
|
PR_Github #15019 [ run ] completed with state |
Signed-off-by: Aurelien Chartier <[email protected]>
|
/bot run |
|
PR_Github #15062 [ run ] triggered by Bot |
|
PR_Github #15062 [ run ] completed with state |
…lation (NVIDIA#6840) Signed-off-by: Aurelien Chartier <[email protected]>
…lation (NVIDIA#6840) Signed-off-by: Aurelien Chartier <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
…lation (NVIDIA#6840) Signed-off-by: Aurelien Chartier <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
…lation (NVIDIA#6840) Signed-off-by: Aurelien Chartier <[email protected]>
…lation (NVIDIA#6840) Signed-off-by: Aurelien Chartier <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
…lation (NVIDIA#6840) Signed-off-by: Aurelien Chartier <[email protected]>
…lation (NVIDIA#6840) Signed-off-by: Aurelien Chartier <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
Summary by CodeRabbit
Description
Follow up to #5898
Test Coverage
New test
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.