[Infra] - Add wiave list for pytest when using slurm #6130
Conversation
Signed-off-by: qqiao <[email protected]>
WalkthroughThis update introduces support for a "waives.txt" file in the SLURM multi-node test workflow. The file is uploaded to the remote workspace, its path is exported as an environment variable, and the test execution command is updated to include this file using a new argument. Changes
Sequence Diagram(s)sequenceDiagram
participant Local as Local Workspace
participant Remote as Remote Node
participant Script as slurm_run.sh
Local->>Remote: Upload slurm_run.sh and waives.txt
Remote->>Script: Launch slurm_run.sh with exported waivesListPathNode
Script->>Script: Run pytest with --waives-file=$waivesListPathNode
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
EmmaQiaoCh
requested review from
niukuo,
ZhanruiSunCh and
yiqingy0
and removed request for
chzblych
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
jenkins/L0_Test.groovy(3 hunks)jenkins/scripts/slurm_run.sh(1 hunks)
🔇 Additional comments (3)
jenkins/scripts/slurm_run.sh (1)
48-48: LGTM! Clean addition of waives file support.The addition of the
--waives-file=$waivesListPathNodeargument to the test command line is straightforward and correctly implements the waives file functionality for SLURM pytest execution.jenkins/L0_Test.groovy (2)
312-312: LGTM! Consistent variable declaration pattern.The declaration of
waivesListPathNodefollows the same pattern as other path variables in the function and correctly points to the job workspace location.
370-370: LGTM! Correct environment variable export.The export of
waivesListPathNodeenvironment variable ensures it's available in the test execution script, maintaining consistency with other exported variables.
|
/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2" |
Signed-off-by: qqiao <[email protected]>
|
/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1, GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2" |
|
PR_Github #12163 [ run ] triggered by Bot |
|
PR_Github #12165 [ run ] triggered by Bot |
|
PR_Github #12163 [ run ] completed with state |
|
PR_Github #12165 [ run ] completed with state |
|
/bot skip --comment "tested for specified stages, tests skipped in jobs" |
|
PR_Github #12184 [ skip ] triggered by Bot |
|
PR_Github #12184 [ skip ] completed with state |
Signed-off-by: qqiao <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Signed-off-by: qqiao <[email protected]> Co-authored-by: Emma Qiao <[email protected]>
Signed-off-by: qqiao <[email protected]>
PR title
Please write the PR title by following template:
[JIRA ticket link/nvbug link/github issue link][fix/feat/doc/infra/...] <summary of this PR>
For example, assume I have a PR hope to support a new feature about cache manager of Jira TRTLLM-1000 ticket, it would be like
[TRTLLM-1000][feat] Support a new feature about cache manager
Description
Please explain the issue and the solution in short.
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.md.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.
Summary by CodeRabbit