[None][infra] Cherry-pick #6128 and #6130 from main branch #6151
Conversation
Signed-off-by: Yanchao Lu <[email protected]>
Signed-off-by: qqiao <[email protected]>
WalkthroughA new Changes
Sequence Diagram(s)sequenceDiagram
participant Jenkins as Jenkins Pipeline
participant Node as Remote Node
participant Pytest as Pytest
Jenkins->>Node: Upload test list and waives.txt via scp
Jenkins->>Node: Generate job launch script exporting waivesListPathNode
Node->>Pytest: Invoke pytest with --waives-file=$waivesListPathNode
Pytest-->>Node: Access waives.txt during test execution
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
coderabbitai
bot
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
jenkins/scripts/slurm_run.sh (1)
49-56: Quote-splitting bug across several array itemsArray elements that embed spaces (
"--rootdir $llmSrcNode/tests/integration/defs","--splits $splits","--group $splitId") will be re-split when${testCmdLines[*]}iseval-ed, turning each into two separate arguments and breaking PyTest parsing.Safer pattern:
testCmdLines+=( "--rootdir" "$llmSrcNode/tests/integration/defs" "--splits" "$splits" "--group" "$splitId" )Refactoring now will avoid hard-to-diagnose CI failures.
🧹 Nitpick comments (3)
.coderabbit.yaml (1)
16-23: Validate YAML keys & consider conditionalcommit_statususageThe structure is schema-compliant, but two quick checks are worthwhile:
commit_status: falsesuppresses PR-check updates from CodeRabbit. If your workflow (e.g. Gerrit/Jenkins gating) relies on commit status, this will silently disable it.base_branches: ["main", "release/.+"]is accepted, yet a more explicit pattern such asrelease/.*is often clearer for readers.No action required if this is intentional, otherwise adjust:
- base_branches: ["main", "release/.+"] + base_branches: ["main", "release/.*"] - commit_status: false +# commit_status: true # enable if downstream jobs depend on it.github/pull_request_template.md (1)
12-15: Minor Markdown formatting issue in the link example
[https://nvbugs/1234567][fix]renders the raw URL as the link text. If the intent is a clickable link with descriptive text, use standard Markdown:[fix] [NVBug 1234567](https://nvbugs/1234567)jenkins/L0_Test.groovy (1)
329-332: Consider adding error handling for missing waives.txt fileThe scp command will fail if the waives.txt file doesn't exist at the expected local path. Consider adding a file existence check or error handling to gracefully handle cases where the waives file might be missing.
// Upload waives.txt to Frontend node def waivesListLocalPath = "${llmSrcLocal}/tests/integration/test_lists/waives.txt" + // Check if waives.txt exists before attempting to copy + if (sh(script: "test -f ${waivesListLocalPath}", returnStatus: true) == 0) { Utils.exec(pipeline, script: "sshpass -p '${remote.passwd}' scp -r -p -oStrictHostKeyChecking=no ${waivesListLocalPath} ${remote.user}@${remote.host}:${waivesListPathNode}",) + } else { + echo "Warning: waives.txt not found at ${waivesListLocalPath}, skipping upload" + }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.coderabbit.yaml(1 hunks).github/pull_request_template.md(1 hunks)jenkins/L0_Test.groovy(3 hunks)jenkins/scripts/slurm_run.sh(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (2)
jenkins/L0_Test.groovy (2)
312-312: LGTM - Consistent variable declarationThe
waivesListPathNodevariable follows the same naming convention and path construction pattern as other similar variables in the function.
370-370: LGTM - Proper environment variable exportThe environment variable export follows the correct syntax and naming convention, making the waives file path available to the remote execution environment.
|
/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-[Post-Merge]-1, GB200-8_GPUs-2_Nodes-PyTorch-[Post-Merge]-2, GB200-8_GPUs-2_Nodes-PyTorch-[Post-Merge]-3, GB200-8_GPUs-2_Nodes-PyTorch-[Post-Merge]-4" |
chzblych
changed the title
|
PR_Github #12219 [ run ] triggered by Bot |
|
PR_Github #12219 [ run ] completed with state |
|
/bot skip --comment "Related test stages passed" |
|
PR_Github #12260 [ skip ] triggered by Bot |
|
PR_Github #12260 [ skip ] completed with state |
Summary by CodeRabbit
Description
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.md.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.