[https://nvbugs/5430125][ci] Unwaive test case for mistral 3.1 small #7265

2ez4bz · 2025-08-26T17:34:34Z

Summary by CodeRabbit

Tests
- Re-enabled a previously skipped multimodal quickstart test by removing a waiver, increasing test coverage and validation of image+text workflows.
- Strengthens CI reliability and helps catch regressions earlier.
- No user-facing functionality changes.
- Improves overall release confidence and stability; expect more consistent quality checks during development.

Description

The timeout in CI was due to prefetching all safetensors, which, in mistral checkpoints' case, included the consolidated safetensor. This was fixed with #7225, so we unwaive related tests.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: William Zhang <[email protected]>

coderabbitai · 2025-08-26T17:34:43Z

📝 Walkthrough

Walkthrough

Removed one waiver entry from tests/integration/test_lists/waives.txt, enabling the previously skipped E2E test for the mistral-small-3.1 multimodal configuration to run.

Changes

Cohort / File(s)	Summary of edits
Waiver removal `tests/integration/test_lists/waives.txt`	Deleted a single SKIP/waiver line for `test_e2e.py::test_ptp_quickstart_multimodal[...]`, unskipping that test.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

[https://nvbugs/5445774][fix] Unwaive Gemma3 27B fp8 test #6799 — Also removes specific SKIP entries from tests/integration/test_lists/waives.txt.
[test] Unwaive mistral3.1 small E2E test #6352 — Un-waives Mistral 3.1 small E2E tests by editing the same waiver file.
[None][infra] Waive failed cases on main 08/14 #6902 — Adjusts waiver entries in tests/integration/test_lists/waives.txt (updates/additions).

Suggested reviewers

brb-nv
venkywonka
EmmaQiaoCh

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 34c1e9c and aebfc43.

📒 Files selected for processing (1)

tests/integration/test_lists/waives.txt (0 hunks)

💤 Files with no reviewable changes (1)

tests/integration/test_lists/waives.txt

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

2ez4bz · 2025-08-26T17:37:43Z

/bot run --extra-stage "H100_PCIe-PyTorch-Post-Merge-1"

tensorrt-cicd · 2025-08-26T17:43:39Z

PR_Github #16584 [ run ] triggered by Bot

tensorrt-cicd · 2025-08-26T21:32:00Z

PR_Github #16584 [ run ] completed with state SUCCESS
/LLM/release-1.0/L0_MergeRequest_PR pipeline #314 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

…7265) Signed-off-by: William Zhang <[email protected]>

…VIDIA#7265) Signed-off-by: William Zhang <[email protected]> Signed-off-by: Wangshanshan <[email protected]>

[https://nvbugs/5430124][ci] Unwaive test case for mistral 3.1 small

aebfc43

Signed-off-by: William Zhang <[email protected]>

2ez4bz requested a review from a team as a code owner August 26, 2025 17:34

2ez4bz changed the title ~~[https://nvbugs/5430124][ci] Unwaive test case for mistral 3.1 small~~ [https://nvbugs/5430125][ci] Unwaive test case for mistral 3.1 small Aug 26, 2025

venkywonka approved these changes Aug 26, 2025

View reviewed changes

MartinMarciniszyn approved these changes Aug 26, 2025

View reviewed changes

MartinMarciniszyn enabled auto-merge (squash) August 26, 2025 18:52

MartinMarciniszyn merged commit b6eba85 into NVIDIA:release/1.0 Aug 26, 2025
6 checks passed

yuanjingx87 pushed a commit that referenced this pull request Aug 28, 2025

[https://nvbugs/5430125][ci] Unwaive test case for mistral 3.1 small (#…

e155ac0

…7265) Signed-off-by: William Zhang <[email protected]>

coderabbitai bot mentioned this pull request Sep 1, 2025

[https://nvbugs/5445466][fix] unwaive DS R1 test cases with bug already fixed #7429

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[https://nvbugs/5430125][ci] Unwaive test case for mistral 3.1 small #7265

[https://nvbugs/5430125][ci] Unwaive test case for mistral 3.1 small #7265

Uh oh!

2ez4bz commented Aug 26, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Aug 26, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

Status, Documentation and Community

Uh oh!

2ez4bz commented Aug 26, 2025

Uh oh!

tensorrt-cicd commented Aug 26, 2025

Uh oh!

tensorrt-cicd commented Aug 26, 2025

Uh oh!

Uh oh!

Uh oh!

[https://nvbugs/5430125][ci] Unwaive test case for mistral 3.1 small #7265

[https://nvbugs/5430125][ci] Unwaive test case for mistral 3.1 small #7265

Uh oh!

Conversation

2ez4bz commented Aug 26, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

GitHub Bot Help

kill

skip

reuse-pipeline

Uh oh!

coderabbitai bot commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

Status, Documentation and Community

Uh oh!

2ez4bz commented Aug 26, 2025

Uh oh!

tensorrt-cicd commented Aug 26, 2025

Uh oh!

tensorrt-cicd commented Aug 26, 2025

Uh oh!

Uh oh!

Uh oh!

2ez4bz commented Aug 26, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 26, 2025 •

edited

Loading