[https://nvbugs/5445466][fix] unwaive DS R1 test cases with bug already fixed #7429

lancelly · 2025-09-01T07:47:28Z

Re-enabled multiple previously skipped integration tests by removing waivers, expanding coverage across performance and accuracy scenarios for relevant model configurations. This enhances validation and release confidence without altering product behavior or interfaces. No new waivers were added; only deletions occurred. No changes to exported/public entities. End users should not see functional changes.

Summary by CodeRabbit

Tests
- Re-enabled previously skipped DeepSeekR1 performance and accuracy tests for LLM API and GB200 full-path runs.
- Restores coverage for FP8 blockscale and NVFP4 multi‑GPU scenarios across latency and throughput variants, improving validation across configurations.
- No changes to product behavior, APIs, or user-facing functionality.

Signed-off-by: Lanyu Liao <[email protected]>

lancelly · 2025-09-01T07:48:44Z

/bot run --add-multi-gpu-test --disable-fail-fast

coderabbitai · 2025-09-01T07:49:18Z

📝 Walkthrough

Walkthrough

Removes several SKIP entries from tests/integration/test_lists/waives.txt, re-enabling DeepSeekR1 tests for FP8 blockscale and NVFP4 multi-GPU throughput/latency variants, including GB200 full-path entries. No code or API changes.

Changes

Cohort / File(s)	Summary
Test waiver updates (DeepSeekR1) `tests/integration/test_lists/waives.txt`	Deleted SKIP lines for DeepSeekR1: FP8 blockscale [latency, throughput], NVFP4 multi_gpus [throughput_tp8, throughput, throughput_mtp]; also removed corresponding `full:GB200/...` entries. No additions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

[None][infra] Waive failed cases on main 08/14 #6902 — Also modifies waives.txt around DeepSeekR1 skip entries, making it directly related.
[https://nvbugs/5455140][fix] unwaive DSR1-fp4 throughput_tp8 #7022 — Touches the same TestDeepSeekR1::test_nvfp4_multi_gpus[throughput_tp8] waiver entry.
[https://nvbugs/5430125][ci] Unwaive test case for mistral 3.1 small #7265 — Removes SKIP/waiver entries in waives.txt for integration tests, similar scope.

Suggested reviewers

litaotju
yiqingy0

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2b286ae and a36aca6.

📒 Files selected for processing (1)

tests/integration/test_lists/waives.txt (0 hunks)

💤 Files with no reviewable changes (1)

tests/integration/test_lists/waives.txt

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

tensorrt-cicd · 2025-09-01T07:54:14Z

PR_Github #17177 [ run ] triggered by Bot

Signed-off-by: Lanyu Liao <[email protected]>

lancelly · 2025-09-01T09:51:03Z

/bot kill

lancelly · 2025-09-01T11:07:20Z

/bot run --add-multi-gpu-test --disable-fail-fast

tensorrt-cicd · 2025-09-01T12:24:37Z

PR_Github #17177 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #12913 completed with status: 'FAILURE'

lancelly · 2025-09-01T13:23:25Z

/bot run --add-multi-gpu-test --disable-fail-fast

tensorrt-cicd · 2025-09-01T13:29:56Z

PR_Github #17220 [ run ] triggered by Bot

tensorrt-cicd · 2025-09-01T16:37:14Z

PR_Github #17220 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #12948 completed with status: 'FAILURE'

lancelly · 2025-09-02T01:48:52Z

/bot run --add-multi-gpu-test --disable-fail-fast

lancelly · 2025-09-05T08:04:31Z

/bot run --add-multi-gpu-test --disable-fail-fast

tensorrt-cicd · 2025-09-05T08:09:51Z

PR_Github #17764 [ run ] triggered by Bot

tensorrt-cicd · 2025-09-05T08:09:52Z

PR_Github #17764 [ run ] completed with state DISABLED
L0 testing is limited to prioritized users. User lancelly is not in the prioritized list. L0 testing cannot be triggered.

lancelly · 2025-09-08T03:07:52Z

/bot run --add-multi-gpu-test --disable-fail-fast

tensorrt-cicd · 2025-09-08T03:13:55Z

PR_Github #17968 [ run ] triggered by Bot

tensorrt-cicd · 2025-09-08T06:31:21Z

PR_Github #17968 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #13467 completed with status: 'FAILURE'

Signed-off-by: Lanyu Liao <[email protected]>

lancelly · 2025-09-08T07:23:28Z

/bot run --add-multi-gpu-test --disable-fail-fast

tensorrt-cicd · 2025-09-08T07:29:36Z

PR_Github #17997 [ run ] triggered by Bot

tensorrt-cicd · 2025-09-08T16:09:09Z

PR_Github #17997 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #13488 completed with status: 'FAILURE'

lancelly · 2025-09-09T00:46:24Z

/bot run --add-multi-gpu-test --disable-fail-fast

lancelly · 2025-09-09T06:12:22Z

/bot run

tensorrt-cicd · 2025-09-09T06:17:53Z

PR_Github #18170 [ run ] triggered by Bot

tensorrt-cicd · 2025-09-09T07:59:36Z

PR_Github #18170 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #13616 completed with status: 'SUCCESS'

Signed-off-by: Lanyu Liao <[email protected]>

litaotju · 2025-09-09T09:22:56Z

skip merge since only a trivial resolve is done.

litaotju · 2025-09-09T09:23:10Z

/bot skip --comment "skip since a full pipeline passed"

tensorrt-cicd · 2025-09-09T09:28:05Z

PR_Github #18205 [ ] completed with state FAILURE
Not allowed on merged PR

…dy fixed (NVIDIA#7429) Signed-off-by: Lanyu Liao <[email protected]> Co-authored-by: Lanyu Liao <[email protected]> Signed-off-by: Gergely Magyar <[email protected]>

…dy fixed (NVIDIA#7429) Signed-off-by: Lanyu Liao <[email protected]> Co-authored-by: Lanyu Liao <[email protected]>

lancelly added 2 commits September 1, 2025 00:38

unwaive ds tests

1a1ddf3

Signed-off-by: Lanyu Liao <[email protected]>

unwaive ds tests

a36aca6

Signed-off-by: Lanyu Liao <[email protected]>

lancelly changed the title ~~[https://nvbugs/5445466][fix] unwaive DS R1 test cases with bug already fixed #7392~~ [https://nvbugs/5445466][fix] unwaive DS R1 test cases with bug already fixed Sep 1, 2025

lancelly requested review from EmmaQiaoCh and litaotju September 1, 2025 07:47

resolve conflicts

5345de7

Signed-off-by: Lanyu Liao <[email protected]>

litaotju approved these changes Sep 3, 2025

View reviewed changes

lancelly added 2 commits September 7, 2025 23:59

Merge branch 'main' into unwaive_ds_tests

ba2a7bb

Merge branch 'main' into unwaive_ds_tests

11d122d

Signed-off-by: Lanyu Liao <[email protected]>

lancelly added 2 commits September 9, 2025 02:15

merge

e43eaa9

Signed-off-by: Lanyu Liao <[email protected]>

merge

c36b677

Signed-off-by: Lanyu Liao <[email protected]>

litaotju merged commit af40384 into NVIDIA:main Sep 9, 2025
4 of 5 checks passed

Wong4j pushed a commit to Wong4j/TensorRT-LLM that referenced this pull request Sep 20, 2025

[https://nvbugs/5445466][fix] unwaive DS R1 test cases with bug alrea…

545011e

…dy fixed (NVIDIA#7429) Signed-off-by: Lanyu Liao <[email protected]> Co-authored-by: Lanyu Liao <[email protected]>

[https://nvbugs/5445466][fix] unwaive DS R1 test cases with bug already fixed #7429

[https://nvbugs/5445466][fix] unwaive DS R1 test cases with bug already fixed #7429

Conversation

lancelly commented Sep 1, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

lancelly commented Sep 1, 2025

Uh oh!

coderabbitai bot commented Sep 1, 2025

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

Status, Documentation and Community

Uh oh!

tensorrt-cicd commented Sep 1, 2025

Uh oh!

lancelly commented Sep 1, 2025

Uh oh!

lancelly commented Sep 1, 2025

Uh oh!

tensorrt-cicd commented Sep 1, 2025

Uh oh!

lancelly commented Sep 1, 2025

Uh oh!

tensorrt-cicd commented Sep 1, 2025

Uh oh!

tensorrt-cicd commented Sep 1, 2025

Uh oh!

lancelly commented Sep 2, 2025

Uh oh!

lancelly commented Sep 5, 2025

Uh oh!

tensorrt-cicd commented Sep 5, 2025

Uh oh!

tensorrt-cicd commented Sep 5, 2025

Uh oh!

lancelly commented Sep 8, 2025

Uh oh!

tensorrt-cicd commented Sep 8, 2025

Uh oh!

tensorrt-cicd commented Sep 8, 2025

Uh oh!

lancelly commented Sep 8, 2025

Uh oh!

tensorrt-cicd commented Sep 8, 2025

Uh oh!

tensorrt-cicd commented Sep 8, 2025

Uh oh!

lancelly commented Sep 9, 2025

Uh oh!

lancelly commented Sep 9, 2025

Uh oh!

tensorrt-cicd commented Sep 9, 2025

Uh oh!

tensorrt-cicd commented Sep 9, 2025

Uh oh!

litaotju commented Sep 9, 2025

Uh oh!

litaotju commented Sep 9, 2025

Uh oh!

Uh oh!

tensorrt-cicd commented Sep 9, 2025

Uh oh!

Uh oh!

lancelly commented Sep 1, 2025 •

edited by coderabbitai bot

Loading