[None][ci] Cherry-pick some improvements for Slurm CI setup from main branch #7479
Conversation
Signed-off-by: Yanchao Lu <[email protected]>
…CI codes (NVIDIA#7417) Signed-off-by: Yanchao Lu <[email protected]>
|
/bot run |
📝 Walkthrough✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
jenkins/L0_Test.groovy (1)
520-539: Preserve srun exit code through teetee can mask pipeline status. Use pipefail and propagate srun’s status.
Apply this diff inside scriptContent:
- def scriptContent = """#!/bin/bash + def scriptContent = """#!/bin/bash + set -o pipefail @@ - ${srunCmd} 2>&1 | tee ${slurmOutputFile} + ${srunCmd} 2>&1 | tee ${slurmOutputFile} + exit ${PIPESTATUS[0]} """.stripIndent()
🧹 Nitpick comments (4)
jenkins/L0_Test.groovy (4)
184-191: Post-submit log rename is reasonable; consider preserving srun exit codeRenaming slurm-%j to the real ID helps traceability. To avoid masking srun failures due to tee, wire pipefail where the file is produced (see comment at Lines 520-539).
207-212: Replace fixed sleeps with readiness checksStatic 30s sleeps slow pipelines and are brittle. Prefer polling CloudManager/node status (e.g., wait until node gone) with a max timeout.
466-466: Ensure Slurm logs directory exists on FE nodeBefore tee writes to ${slurmOutputFile}, create the parent dir remotely (mkdir -p) to avoid silent log-loss if the path is missing.
1886-1902: Ignore known Docker kill noise, but narrow the matchCatching by message substring is brittle. If possible, match the specific exception class or regex the exact known message and log stacktrace at debug for other IOEs.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
jenkins/L0_Test.groovy(21 hunks)jenkins/scripts/slurm_run.sh(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Filenames compiled into a target must be case-insensitively unique
Files:
jenkins/scripts/slurm_run.shjenkins/L0_Test.groovy
🧠 Learnings (2)
📚 Learning: 2025-08-27T14:23:55.566Z
Learnt from: ixlmar
PR: NVIDIA/TensorRT-LLM#7294
File: tensorrt_llm/_torch/modules/rms_norm.py:17-17
Timestamp: 2025-08-27T14:23:55.566Z
Learning: The TensorRT-LLM project requires Python 3.10+ as evidenced by the use of TypeAlias from typing module, match/case statements, and union type | syntax throughout the codebase, despite some documentation still mentioning Python 3.8+.
Applied to files:
jenkins/scripts/slurm_run.sh
📚 Learning: 2025-08-01T15:14:45.673Z
Learnt from: yibinl-nvidia
PR: NVIDIA/TensorRT-LLM#6506
File: examples/models/core/mixtral/requirements.txt:3-3
Timestamp: 2025-08-01T15:14:45.673Z
Learning: In TensorRT-LLM, examples directory can have different dependency versions than the root requirements.txt file. Version conflicts between root and examples dependencies are acceptable because examples are designed to be standalone and self-contained.
Applied to files:
jenkins/scripts/slurm_run.sh
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (7)
jenkins/scripts/slurm_run.sh (1)
25-25: GPU diagnostics chaining looks goodChaining nvidia-smi/-q/topo is fine and reduces noise if GPUs are absent. No change requested.
jenkins/L0_Test.groovy (6)
157-160: Hardened Slurm job ID extractionAdding SLURM_JOB_ID/SLURM_JOBID patterns is a good robustness win.
323-334: Expanded Slurm ID parsing LGTMCovers more submit outputs and logs submission output on failure. Good.
966-973: Host node name resolution LGTMPrefers HOST_NODE_NAME with sane fallback; concise and robust.
698-698: Non-fatal dmesg collectionGood change; avoids aborting when dmesg is restricted.
1048-1048: Richer GPU diagnosticsStandardizing on nvidia-smi && nvidia-smi -q && nvidia-smi topo -m improves triage. Looks good.
Also applies to: 1456-1456, 1832-1832
1919-1937: AlllaunchTestJobscall sites updated to the new two-parameter signature
No occurrences of the old three-argument signature remain in the repository.
|
PR_Github #17353 [ run ] triggered by Bot |
|
PR_Github #17353 [ run ] completed with state |
|
/bot run |
|
PR_Github #17427 [ run ] triggered by Bot |
|
PR_Github #17427 [ run ] completed with state |
[None][ci] Some improvements for Slurm CI setup #7407
[None][ci] Correct docker args for GPU devices and remove some stale CI codes #7417
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.