[None][ci] Block some nodes to avoid unstable network access #7593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/bot run --stage-list "Build-Docker-Images" |
📝 WalkthroughWalkthroughAdds AMD64-specific nodeAffinity exclusions to Jenkins Kubernetes pod config when building wheels. Modifies Slurm polling in L0 tests to run scontrol show job each cycle and attempt scontrol release after sleep to avoid held states. No API/signature changes. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Pipeline
participant PodConfig as createKubernetesPodConfig
participant K8s as Kubernetes Scheduler
Pipeline->>PodConfig: build_wheel=true, arch="amd64"
PodConfig->>PodConfig: Append nodeAffinity NotIn for 6 hostnames
PodConfig-->>Pipeline: Pod spec with updated selectors
Pipeline->>K8s: Submit pod with nodeAffinity
K8s-->>Pipeline: Schedule avoiding excluded nodes
sequenceDiagram
autonumber
participant Pipeline
participant SSH as Remote SSH
participant Slurm as scontrol
loop Poll until completion/timeout
Pipeline->>SSH: scontrol show job ${slurmJobID}
SSH->>Slurm: show job
Slurm-->>SSH: job status
SSH-->>Pipeline: status output
Pipeline->>Pipeline: sleep N seconds
Pipeline->>SSH: scontrol release ${slurmJobID} || true
SSH->>Slurm: release (noop if not held)
Slurm-->>SSH: ack/err (ignored)
SSH-->>Pipeline: return
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
jenkins/L0_Test.groovy (2)
351-363: Fix: undefined ‘remote’, wrong helper reference, and missing named arg.
- remote is out of scope here (defined inside a previous withCredentials block).
- Use Utils.sshUserCmd(...) (current code calls sshUserCmd unqualified).
- Prefer passing script: named arg to Utils.exec for consistency.
Patch:
- def counter = 0 - // We submit the Slurm job with 5 hours timeout, and the K8S pod will be evicted after 22 hours. - // Let's use 15 hours to check if the node is online, and with 2 hours buffer. - while (!CloudManager.isNodeOnline(nodeName) && counter < 90) { - // Test - Utils.exec(pipeline, sshUserCmd(remote, "\"scontrol show job ${slurmJobID} || true\"")) - // Wait 10 minutes to check status of the node again - sleep(time: 10, unit: 'MINUTES') - // Avoid the node being stuck in the held state. - Utils.exec(pipeline, sshUserCmd(remote, "\"scontrol release ${slurmJobID} || true\"")) - counter++ - } + def counter = 0 + // We submit the Slurm job with 5 hours timeout, and the K8S pod will be evicted after 22 hours. + // Let's use 15 hours to check if the node is online, and with 2 hours buffer. + withCredentials([usernamePassword(credentialsId: 'svc_tensorrt', usernameVariable: 'USERNAME', passwordVariable: 'PASSWORD')]) { + def remote = [ + ip : cluster.ip, + host : cluster.host, + user : "${pipeline.USERNAME}", + passwd : "${pipeline.PASSWORD}", + allowAnyHosts: true, + ] + while (!CloudManager.isNodeOnline(nodeName) && counter < 90) { + // Inspect status each cycle + Utils.exec(pipeline, script: Utils.sshUserCmd(remote, "\"scontrol show job ${slurmJobID} || true\"")) + // Wait 10 minutes to check status of the node again + sleep(time: 10, unit: 'MINUTES') + // Try to release held jobs + Utils.exec(pipeline, script: Utils.sshUserCmd(remote, "\"scontrol release ${slurmJobID} || true\"")) + counter++ + } + }
351-363: EnforceUtils.sshUserCmdusage and namedscript:argument forUtils.exec
- In jenkins/L0_Test.groovy (around lines 155–158, 174–178, 184–188, 225–229, 235–239, 315–319, 355–363, 564–568), replace all bare
sshUserCmdcalls withUtils.sshUserCmd.- For each
Utils.exec(pipeline, sshUserCmd(…))invocation, switch to named-arg form:
Utils.exec(pipeline, script: Utils.sshUserCmd(…)).
🧹 Nitpick comments (2)
jenkins/BuildDockerImage.groovy (1)
97-115: Externalize the blocklist to config to ease maintenance.Consider moving these hostnames into a single constant/env var (or shared-lib helper) so ops can adjust without code edits; add a short comment with rationale/expiry.
jenkins/L0_Test.groovy (1)
351-363: Optional: skip remote calls if slurmJobID is invalid.Add a quick guard to avoid pointless SSH when submission failed.
Example:
if (!(slurmJobID?.isNumber())) { sleep(time: 10, unit: 'MINUTES'); counter++; continue }
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
jenkins/BuildDockerImage.groovy(1 hunks)jenkins/L0_Test.groovy(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (1)
jenkins/BuildDockerImage.groovy (1)
97-115: AMD64 wheel-build NotIn affinity looks correct.The NotIn rule aligns with the stated goal and keeps other selectors intact. No functional concerns from me.
|
PR_Github #17943 [ run ] triggered by Bot |
chzblych
force-pushed
the
yanchaol-docker-build
branch
2 times, most recently
from
1346c92 to
860570d
Compare
Signed-off-by: Yanchao Lu <[email protected]>
chzblych
force-pushed
the
yanchaol-docker-build
branch
from
860570d to
5982bba
Compare
chzblych
added a commit
that referenced
this pull request
Sep 7, 2025
Signed-off-by: Yanchao Lu <[email protected]>
|
PR_Github #17943 [ run ] completed with state |
Wong4j
pushed a commit
to Wong4j/TensorRT-LLM
that referenced
this pull request
Sep 20, 2025
…7593) Signed-off-by: Yanchao Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.