-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[None][chore] Add failed cases into waives.txt #7746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[None][chore] Add failed cases into waives.txt #7746
Conversation
7e998f3
to
3ffc462
Compare
/bot run --skip-test |
PR_Github #18683 [ run ] triggered by Bot |
📝 WalkthroughWalkthroughAdds five SKIP entries to tests/integration/test_lists/waives.txt for DeepSeekV3Lite tests and two E2E tests, citing nvbugs 5519462, 5347051, 5453725, and 5517260. No source code changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
359-359
: Scope this waiver to A100 (avoid platform-agnostic SKIP).Nearby DeepSeek waivers (lines 355–358) are already gated with full:A100 — make this entry consistent to reduce blast radius.
-test_e2e.py::test_ptp_scaffolding[DeepSeek-R1-Distill-Qwen-7B-DeepSeek-R1/DeepSeek-R1-Distill-Qwen-7B] SKIP (https://nvbugs/5517260) +full:A100/test_e2e.py::test_ptp_scaffolding[DeepSeek-R1-Distill-Qwen-7B-DeepSeek-R1/DeepSeek-R1-Distill-Qwen-7B] SKIP (https://nvbugs/5517260)
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-29T14:07:45.863Z
Learnt from: EmmaQiaoCh
PR: NVIDIA/TensorRT-LLM#7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.
Applied to files:
tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (3)
tests/integration/test_lists/waives.txt (3)
357-357
: bfloat16 waiver LGTM; confirm full param tuple matches exactly.
accuracy/test_llm_api_pytorch.py was not found in the repo; confirm the bracketed tuple in tests/integration/test_lists/waives.txt:357 exactly matches the test’s parametrization.
358-358
: Scope check — can't verify: test_e2e.py missing; confirm whether NVILA video quickstart waiver should be A100‑only
- rg returned "No such file or directory" for test_e2e.py; waiver is at tests/integration/test_lists/waives.txt:358 and I couldn't locate the referenced test to confirm scope.
- If the failure isn't A100‑specific, mirror the waiver to other lanes; otherwise keep as‑is. Also verify the "video" param‑ID spelling (compare to the "image" waiver at line 260).
355-356
: Approve A100 DeepSeekV3Lite auto_dtype waivers — param IDs & nvbug verified.Waives present at tests/integration/test_lists/waives.txt lines 355–356 point to nvbug 5519462; TestDeepSeekV3Lite exists (tests/integration/defs/accuracy/test_disaggregated_serving.py:658) and the parametrized test_auto_dtype (mtp_nextn/overlap_scheduler) is defined at line 704. Param-ID usage matches other test lists — no changes required.
3ffc462
to
eef7d2b
Compare
PR_Github #18683 [ run ] completed with state |
eef7d2b
to
a76aded
Compare
/bot reuse-pipeline |
a76aded
to
3eace9f
Compare
/bot reuse-pipeline |
PR_Github #18762 [ reuse-pipeline ] triggered by Bot |
3eace9f
to
4bf8c14
Compare
PR_Github #18762 [ reuse-pipeline ] completed with state |
Signed-off-by: Xin He (SW-GPU) <[email protected]>
4bf8c14
to
1b7ae8d
Compare
/bot reuse-pipeline |
PR_Github #18780 [ reuse-pipeline ] triggered by Bot |
PR_Github #18780 [ reuse-pipeline ] completed with state |
Signed-off-by: Xin He (SW-GPU) <[email protected]>
Signed-off-by: Xin He (SW-GPU) <[email protected]>
waive failed cases.
Summary by CodeRabbit