Skip to content

Conversation

xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Sep 16, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Expanded test-skip configuration to waive several integration, E2E, and accuracy tests for specific model/configuration combinations tied to known issues.
    • Reduces CI noise and false failures while investigations continue.
    • No changes to product features or runtime behavior; end users are unaffected.

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250916_DEBUG_LLM_FUNCTION_TEST_1759 branch from 7e998f3 to 3ffc462 Compare September 16, 2025 01:39
@xinhe-nv xinhe-nv marked this pull request as ready for review September 16, 2025 01:39
@xinhe-nv xinhe-nv enabled auto-merge (squash) September 16, 2025 01:40
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18683 [ run ] triggered by Bot

Copy link
Contributor

coderabbitai bot commented Sep 16, 2025

📝 Walkthrough

Walkthrough

Adds five SKIP entries to tests/integration/test_lists/waives.txt for DeepSeekV3Lite tests and two E2E tests, citing nvbugs 5519462, 5347051, 5453725, and 5517260. No source code changes.

Changes

Cohort / File(s) Summary
Test waivers
tests/integration/test_lists/waives.txt
Added 5 SKIP entries: DeepSeekV3Lite auto-dtype (overlap_scheduler False/True), DeepSeekV3Lite bfloat16, E2E quickstart multimodal (NVILA-8B-FP16-vila), and E2E scaffolding (DeepSeek-R1-Distill-Qwen-7B); includes nvbugs 5519462, 5347051, 5453725, 5517260.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description "waive failed cases." is too brief and does not follow the repository's required template: it lacks the '@coderabbitai summary' header, a descriptive Explanation of which tests were waived and why, a Test Coverage section, and PR Checklist confirmation. The raw changes add specific SKIP entries to tests/integration/test_lists/waives.txt referencing NVBugs IDs, but those details and rationale are not documented in the description. Because required template sections and essential details are missing, the description check fails. Please update the PR description to follow the repository template: include a clear Description that lists the exact tests added to waives.txt and the reasons for waiving them (reference NVBugs IDs such as 5519462, 5347051, 5453725, 5517260). Add a Test Coverage section describing which tests validate the change and include CI results or notes. Complete the PR Checklist or explain why items are not applicable, then request a re-review.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "[None][chore] Add failed cases into waives.txt" follows the repository's template and succinctly captures the primary change (adding failing test entries to waives.txt). It names the target file and the intent, so a reviewer scanning history can understand the main change. The phrasing is concise and directly relevant to the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)

359-359: Scope this waiver to A100 (avoid platform-agnostic SKIP).

Nearby DeepSeek waivers (lines 355–358) are already gated with full:A100 — make this entry consistent to reduce blast radius.

-test_e2e.py::test_ptp_scaffolding[DeepSeek-R1-Distill-Qwen-7B-DeepSeek-R1/DeepSeek-R1-Distill-Qwen-7B] SKIP (https://nvbugs/5517260)
+full:A100/test_e2e.py::test_ptp_scaffolding[DeepSeek-R1-Distill-Qwen-7B-DeepSeek-R1/DeepSeek-R1-Distill-Qwen-7B] SKIP (https://nvbugs/5517260)
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 96f11b1 and 3ffc462.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-29T14:07:45.863Z
Learnt from: EmmaQiaoCh
PR: NVIDIA/TensorRT-LLM#7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.

Applied to files:

  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (3)
tests/integration/test_lists/waives.txt (3)

357-357: bfloat16 waiver LGTM; confirm full param tuple matches exactly.
accuracy/test_llm_api_pytorch.py was not found in the repo; confirm the bracketed tuple in tests/integration/test_lists/waives.txt:357 exactly matches the test’s parametrization.


358-358: Scope check — can't verify: test_e2e.py missing; confirm whether NVILA video quickstart waiver should be A100‑only

  • rg returned "No such file or directory" for test_e2e.py; waiver is at tests/integration/test_lists/waives.txt:358 and I couldn't locate the referenced test to confirm scope.
  • If the failure isn't A100‑specific, mirror the waiver to other lanes; otherwise keep as‑is. Also verify the "video" param‑ID spelling (compare to the "image" waiver at line 260).

355-356: Approve A100 DeepSeekV3Lite auto_dtype waivers — param IDs & nvbug verified.

Waives present at tests/integration/test_lists/waives.txt lines 355–356 point to nvbug 5519462; TestDeepSeekV3Lite exists (tests/integration/defs/accuracy/test_disaggregated_serving.py:658) and the parametrized test_auto_dtype (mtp_nextn/overlap_scheduler) is defined at line 704. Param-ID usage matches other test lists — no changes required.

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250916_DEBUG_LLM_FUNCTION_TEST_1759 branch from 3ffc462 to eef7d2b Compare September 16, 2025 02:31
@tensorrt-cicd
Copy link
Collaborator

PR_Github #18683 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #14034 (Partly Tested) completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250916_DEBUG_LLM_FUNCTION_TEST_1759 branch from eef7d2b to a76aded Compare September 16, 2025 04:12
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250916_DEBUG_LLM_FUNCTION_TEST_1759 branch from a76aded to 3eace9f Compare September 16, 2025 08:52
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18762 [ reuse-pipeline ] triggered by Bot

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250916_DEBUG_LLM_FUNCTION_TEST_1759 branch from 3eace9f to 4bf8c14 Compare September 16, 2025 09:10
@tensorrt-cicd
Copy link
Collaborator

PR_Github #18762 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #18683 (Partly Tested) for commit 3eace9f

Signed-off-by: Xin He (SW-GPU) <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250916_DEBUG_LLM_FUNCTION_TEST_1759 branch from 4bf8c14 to 1b7ae8d Compare September 16, 2025 10:20
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18780 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18780 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #18683 (Partly Tested) for commit 1b7ae8d

@xinhe-nv xinhe-nv merged commit e7c1569 into NVIDIA:main Sep 16, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20250916_DEBUG_LLM_FUNCTION_TEST_1759 branch September 16, 2025 10:47
Wong4j pushed a commit to Wong4j/TensorRT-LLM that referenced this pull request Sep 20, 2025
MrGeva pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants