Skip to content

Conversation

xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Sep 17, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Added a skip for a specific integration test scenario to improve CI reliability and reduce false negatives in automated runs.
    • Enhances stability of the test suite without modifying application functionality or performance.
    • No impact on user-facing features, APIs, or configurations.
    • Release artifacts and behavior remain unchanged; this update only affects internal testing workflows.

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250917_LLM_FUNCTION_TEST_1331 branch from 0140f75 to a0561ce Compare September 18, 2025 03:02
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@xinhe-nv xinhe-nv marked this pull request as ready for review September 18, 2025 03:02
Copy link
Contributor

coderabbitai bot commented Sep 18, 2025

📝 Walkthrough

Walkthrough

Adds a new SKIP waiver entry in tests/integration/test_lists/waives.txt for accuracy/test_disaggregated_serving.py::TestDeepSeekV3Lite::test_auto_dtype with parameters mtp_nextn=0 and overlap_scheduler=True, referencing nvbugs/5519462. No other files or functional logic changed.

Changes

Cohort / File(s) Summary
Test waivers
tests/integration/test_lists/waives.txt
Added SKIP entry for accuracy/test_disaggregated_serving.py::TestDeepSeekV3Lite::test_auto_dtype[mtp_nextn=0-overlap_scheduler=True] linked to NV bug 5519462.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description "waive failed cases." does not follow the repository template and is missing required details such as a short explanation of what changed, which exact test(s) were waived and the file modified, the NVBugs/issue reference, Test Coverage information, and confirmation of checklist items, so it is insufficient to evaluate the change. Please update the PR description to follow the template: provide a clear Description explaining why the waiver is needed and what was changed (include tests/integration/test_lists/waives.txt and the exact test name), add the NVBugs or issue link/ID, list relevant Test Coverage checks or validation steps, and confirm the PR checklist items (licensing, codeowners, documentation) before merging.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The title "[https://nvbugs/5519462][fix] skip deepseek test on preHopper" succinctly captures the primary change — adding a skip for the DeepSeek test tied to NV bug 5519462 — and directly matches the waiver entry added to tests/integration/test_lists/waives.txt. It is a single, focused sentence without extraneous details, so a reviewer scanning history will understand the main change. The title therefore aligns with the changeset.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #19099 [ run ] triggered by Bot

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250917_LLM_FUNCTION_TEST_1331 branch from a0561ce to 64aaec6 Compare September 18, 2025 04:08
@tensorrt-cicd
Copy link
Collaborator

PR_Github #19099 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #14327 (Partly Tested) completed with status: 'SUCCESS'

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250917_LLM_FUNCTION_TEST_1331 branch from 64aaec6 to 4395dd4 Compare September 18, 2025 07:35
@xinhe-nv xinhe-nv changed the title [None][chore] Add failed cases into waives.txt [https://nvbugs/5519462][fix] Add failed cases into waives.txt Sep 18, 2025
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@xinhe-nv xinhe-nv enabled auto-merge (squash) September 18, 2025 07:41
@tensorrt-cicd
Copy link
Collaborator

PR_Github #19143 [ run ] triggered by Bot

@xinhe-nv xinhe-nv changed the title [https://nvbugs/5519462][fix] Add failed cases into waives.txt [https://nvbugs/5519462][fix] skip deepseek test on preHopper Sep 18, 2025
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250917_LLM_FUNCTION_TEST_1331 branch from 42b37ad to b8a68de Compare September 18, 2025 08:03
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250917_LLM_FUNCTION_TEST_1331 branch 2 times, most recently from f65bbfb to aee3ef9 Compare September 18, 2025 09:20
@tensorrt-cicd
Copy link
Collaborator

PR_Github #19143 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #14365 (Partly Tested) completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250917_LLM_FUNCTION_TEST_1331 branch from aee3ef9 to b327fe3 Compare September 18, 2025 11:07
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #19188 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #19188 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #19143 (Partly Tested) for commit b327fe3

@xinhe-nv xinhe-nv merged commit d3a9071 into NVIDIA:main Sep 18, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20250917_LLM_FUNCTION_TEST_1331 branch September 18, 2025 12:05
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 19, 2025
Wong4j pushed a commit to Wong4j/TensorRT-LLM that referenced this pull request Sep 20, 2025
MrGeva pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants