Skip to content

chore: dts info for requestPermissions #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2019
Merged

chore: dts info for requestPermissions #175

merged 1 commit into from
Mar 5, 2019

Conversation

tgpetrov
Copy link
Contributor

@tgpetrov tgpetrov commented Mar 1, 2019

PR Checklist

What is the current behavior?

The information for the requestPermissions method is not descriptive enough.

What is the new behavior?

The requestPermissions method is declared to return a Promise.

Related with: #162

@tgpetrov tgpetrov requested a review from a team March 1, 2019 12:31
@ghost ghost assigned tgpetrov Mar 1, 2019
@ghost ghost added the new PR label Mar 1, 2019
@VladimirAmiorkov VladimirAmiorkov merged commit 49224cf into master Mar 5, 2019
@VladimirAmiorkov VladimirAmiorkov deleted the tgpetrov/permissions-type branch March 5, 2019 12:32
@ghost ghost removed the new PR label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirAmiorkov VladimirAmiorkov VladimirAmiorkov approved these changes

Assignees

@tgpetrov tgpetrov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgpetrov @VladimirAmiorkov