-
-
Notifications
You must be signed in to change notification settings - Fork 46
Handle user pressing cancel button, on Android #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If this PR is merged, When user cancels image capture, the promise is rejected with a message "cancelled"
Hi, I tried adding those lines to the plugin, to check if everything was right, but on my Samsung J5 2017 the app still crashed. Debugging, I found out the callback for "activityResult" was called twice, when you take a picture after pressing cancel button the first time. Managed to make the app work by adding
before
|
@andreacappadona17 Thanks for pointing it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @shiv19 and @andreacappadona17. Could you just fix the linting error from the Travis report in order to merge the PR. ('ERROR: camera.android.ts[87, 1]: trailing whitespace')
@shiv19 @andreacappadona17 I cherry-picked the changes and rebased them as we already merged PR #66 and there were some conflicts. The changes will be merges with PR #67 |
Rebased PR #65 fixing its lint error
The changes were merged with PR #67 |
@DimitarTachev and @jlooper Thank you! 😄 |
If this PR is merged,
When user cancels image capture, the promise is rejected with a message "cancelled"
{onAndroid}