Skip to content

Handle user pressing cancel button for ios/ add Error for Android #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2017
Merged

Handle user pressing cancel button for ios/ add Error for Android #66

merged 2 commits into from
Nov 3, 2017

Conversation

aliyksel
Copy link

@aliyksel aliyksel commented Nov 2, 2017

No description provided.

@ghost ghost added the new PR label Nov 2, 2017
@DimitarTachev
Copy link

Geat work, @aliyksel. Could you just fix your linting errors from the travis report here. You might also need to rebase your branch after we merge PR #65 as it contains one more android fix.

@jlooper
Copy link

jlooper commented Nov 3, 2017

Congratulations on this quality PR! Have a badge!
contrib

@DimitarTachev DimitarTachev merged commit 7c08d27 into NativeScript:master Nov 3, 2017
@DimitarTachev DimitarTachev mentioned this pull request Nov 3, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@DimitarTachev DimitarTachev DimitarTachev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
♥ community PR new PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliyksel @DimitarTachev @jlooper