Facing configuration on Android (on take picture).

[ximbor]

This modification should allow to configure camerafacing on take
picture.

[radeva]

Hi @ximbor

Thanks for contributing to nativescript-camera plugin! @DimitarTachev and I revewed you PR and have a question what more it adds to the existing functionality. Is it solving an issue or it is just a clearer way to present the option in the code?

Also, please re-base your branch, cause it is out-of-date and we need this done in order to merge.

Thanks,
Veselina

[ximbor]

Hi Veselina, In Readme.md (in CameraOptions section), it's reported the following item: cameraFacing rear The initial camera facing. Use 'front' for selfies. but the "cameraFacing" parameter didn't seem to be managed inside the takePicture method, in fact the "options" object didn't affect the behavior of takePicture function, as only the following parameters were persisted inside the function: saveToGallery = options.saveToGallery ? true : false; reqWidth = options.width ? options.width * density : 0; reqHeight = options.height ? options.height * density : reqWidth; shouldKeepAspectRatio = types.isNullOrUndefined(options.keepAspectRatio) ? true : options.keepAspectRatio; Hope this could help... Thanks, Simone 2017-12-19 10:00 GMT+01:00 radeva <[email protected]>:

…

Hi @ ximbor Thanks for contributing to nativescript-camera plugin! @DimitarTachev <https://github.com/dimitartachev> and I revewed you PR and have a question what more it adds to the existing functionality. Is it solving an issue or it is just a clearer way to present the option in the code? Also, please re-base your branch, cause it is out-of-date and we need this done in order to merge. Thanks, Veselina — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#80 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVlZkvlf3PXCPa4D6DaHX0ts4_wmE2l5ks5tB3sXgaJpZM4Q4ldG> .

[zbranzov]

I'm closing this in favor of #91