Skip to content

fix: saveToGallery to default to true on both platforms #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2018

Conversation

zbranzov
Copy link
Contributor

@zbranzov zbranzov commented Mar 2, 2018

BREAKING CHANGES:
Until now, saveToGallery property on Android had default value 'false'. To unify it with iOS we enable it by default.

Migration steps:
To preserve the previous behavior on Android you should explicitly set the value in your app.

...
camera.takePicture({saveToGallery:false}) 

@ghost ghost assigned zbranzov Mar 2, 2018
@zbranzov zbranzov force-pushed the zbranzov/front-camera branch from cf8662d to ba6fd98 Compare March 2, 2018 16:08
Copy link

@DimitarTachev DimitarTachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@zbranzov zbranzov merged commit 7f73f07 into master Mar 6, 2018
@ghost ghost removed the in progress label Mar 6, 2018
@lini lini deleted the zbranzov/front-camera branch June 20, 2018 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants