fix: don't update local hashes on livesync #3983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
suggested changes
Oct 8, 2018
| @@ -30,7 +30,7 @@ export abstract class AndroidDeviceLiveSyncServiceBase extends DeviceLiveSyncSer | |||
| const deviceHashService = this.getDeviceHashService(deviceAppData.appIdentifier); | |||
| const currentHashes = await deviceHashService.generateHashesFromLocalToDevicePaths(localToDevicePaths); | |||
| const transferredFiles = await this.transferFilesCore(deviceAppData, localToDevicePaths, projectFilesPath, currentHashes, options); | |||
| await this.updateHashes(deviceAppData, currentHashes, projectData, liveSyncDeviceInfo); | |||
| await this.updateHashesOnDevice(deviceAppData, currentHashes); | |||
There was a problem hiding this comment.
maybe you can use directly:
this.device.fileSystem.updateHashesOnDevice(currentHashes, deviceAppData.appIdentifier);| @@ -30,7 +30,7 @@ export abstract class AndroidDeviceLiveSyncServiceBase extends DeviceLiveSyncSer | |||
| const deviceHashService = this.getDeviceHashService(deviceAppData.appIdentifier); | |||
There was a problem hiding this comment.
we have some duplicate logic in this file and in the AndroidDeviceFileSystem. Instead of calling a method here, you can just call:
this.device.fileSystem.getDeviceHashService(deviceAppData.appIdentifier);With the current implementation we have duplicate cashing of the Hash services
Fatme
force-pushed
the
fatme/fix-android-hashes
branch
from
fa217df to
711a3de
Compare
Fatme
force-pushed
the
fatme/fix-android-hashes
branch
from
711a3de to
fe7bbe3
Compare
This was referenced Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Steps to reproduce:
tns create myApptns run android& stop the commandtns run android& make some changes -> everything is oktns run androidon another device