Issue441 automatic backoff retry on http429 #547
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soxofaan
reviewed
May 9, 2025
| @@ -28,6 +28,7 @@ | |||
| "flake8>=5.0.0", | |||
| "time_machine", | |||
| "pyproj>=3.2.0", # Pyproj is an optional, best-effort runtime dependency | |||
| "re-assert", | |||
There was a problem hiding this comment.
we already have dirty_equals for these kind of things, wee should not add yet another utility here
|
|
||
| assert caplog.messages == [ | ||
| "Starting new HTTPS connection (1): example.test:443", | ||
| ] |
There was a problem hiding this comment.
there are only tests with retries but ending in failure, there are no tests about retries that end up in success
soxofaan
reviewed
May 9, 2025
| import requests | ||
| import requests.adapters | ||
|
|
||
| MAX_RETRIES = 3 |
There was a problem hiding this comment.
default of max 3 retries might be a bit low in practice in combination with default backoff_factor: last attempt will be roughly just be 4 seconds after first attempt, which might be too quick to stop trying
|
Because of conflicts: redoing this PR in #770 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@soxofaan looks like something we can merge easily as this is mostly about using functionality from requests?