-
Notifications
You must be signed in to change notification settings - Fork 42
Automatically retry on 429 Too Many Requests #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
TODO:
|
1d058fe
to
964441e
Compare
openeo/utils/http.py
Outdated
DEFAULT_RETRY_FORCELIST = frozenset( | ||
[ | ||
429, # Too Many Requests | ||
500, # Internal Server Error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's best to not include Internal Server Error
by default for now.
Unlike the others (429/502/503/504) this is a very general error situation, and not something where we can assume that just waiting a bit and retrying will resolve the problem.
While working on the tests, it also occurred to me that this feature introduces a bit of conflict with poll-loop situations like So this needs some more investigation (e.g can the retry config be disabled in particular places or contexts?) |
refs #441, #764