Skip to content

Minor update to the Mutator so that it doesn't try to update false values #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2015

Conversation

Luciam91
Copy link

This will stop the values from failing; may be a better solution?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.25%) to 99.75% when pulling 3648311 on Luciam91:master into 98a582d on Miljar:master.

@Miljar
Copy link
Collaborator

Miljar commented May 10, 2015

Thanks for your contribution. I have written a more elaborate comment on this pull request in #39
Can you please either update your code, or let me know if I should take over?

…s when mapping the data, also updated the mapRawData method to ignore false values
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.25%) to 99.75% when pulling e3edd22 on Luciam91:master into 98a582d on Miljar:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.25%) to 99.75% when pulling 823e994 on Luciam91:master into 98a582d on Miljar:master.

@Miljar
Copy link
Collaborator

Miljar commented May 14, 2015

Can you also add these checks for the Native adapter?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.25%) to 99.75% when pulling 7638eaa on Luciam91:master into 98a582d on Miljar:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.25%) to 99.75% when pulling 7638eaa on Luciam91:master into 98a582d on Miljar:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.25%) to 99.75% when pulling 7638eaa on Luciam91:master into 98a582d on Miljar:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.25%) to 99.75% when pulling 7638eaa on Luciam91:master into 98a582d on Miljar:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.51%) to 99.49% when pulling c61c855 on Luciam91:master into 98a582d on Miljar:master.

@Luciam91
Copy link
Author

Added the test to the Native mapper as well; however I cannot for the life of me work out why the code coverage doesn't catch the exception line of code...

@Miljar
Copy link
Collaborator

Miljar commented May 15, 2015

I can't figure it out either. Thanks for updating your PR. Maybe one day we'll figure out what's wrong with the coverage ;)

Miljar added a commit that referenced this pull request May 15, 2015
Minor update to the Mutator so that it doesn't try to update false values
@Miljar Miljar merged commit 4604eb0 into PHPExif:master May 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants