-
Notifications
You must be signed in to change notification settings - Fork 580
op/glob.t failing on macos monterey for 5.38.0-RC1 #21156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It appears that the purpose of the first unit test in
In |
This happens on the 1st run after |
It isn't clear to me if the way the test is being invoked is correct. The test should exclude op/hook and I wonder if it's being executed right. What happens if you do:
|
I will take a look at this as I added t/op/hook |
The same happens after global
|
Ok, interesting. Can you change the code in glob.t to this:
and tell me what it says please? |
@jkeenan said:
Actually that is wrong, this test is checking to see if the perl code |
|
Sorry, one more diff to apply and try
I can't see why t/op/hook is being handled differently than the rest of the files. It is peculiar. |
The difference is funny and would be lost after pasting here. Since you're calling external ls, it respects everything in %ENV. Which is inherited from the calling shell. Including such things as LSCOLORS, CLICOLORS and CLICOLORS_FORCE. Setting the last one is enough to trigger this. The actual key in %ls_files was "op/\x1B[1m\x1B[34mhook\x1B[39;49m\x1B[0m". |
Yep, that explains it nicely. I think the idea of piping to cat is to disable such settings, but CLICOLORS_FORCE would add colors even though it is outputting to a pipe and not the normal STDOUT. I'll prepare a patch, thanks for your help! |
Confirmed on FreeBSD.
|
Curious, if you look closely you and @dur-randir have used different settings, he said CLICOLORS_FORCE and you said CLICOLOR_FORCE=1 (notice the S is missing). Is this a portability issue? |
No, just misspelling on my part. I didn't copy it but retyped - it's really without S. Only LSCOLORS is with S. |
Agree with @dur-randir . On FreeBSD, we have:
|
Disable any ENV vars with the word "color", "ls" or "cli" in them (case insensitively) before running ls. This appears to mostly be a BSD/darwin issue, but we do it on all platforms where we call ls in an abundance of caution. Fixes #21156.
Fix pushed. @rjbs you might want to include this in 5.38. |
Disable any ENV vars with the word "color", "ls" or "cli" in them (case insensitively) before running ls. This appears to mostly be a BSD/darwin issue, but we do it on all platforms where we call ls in an abundance of caution. Fixes #21156.
Disable any ENV vars with the word "color", "ls" or "cli" in them (case insensitively) before running ls. This appears to mostly be a BSD/darwin issue, but we do it on all platforms where we call ls in an abundance of caution. Fixes Perl#21156.
Description
op/glob.t fails with the following
Steps to Reproduce
Run test suite for perl-5.38.0-RC1 on macos monterey 12.6.5.
Expected behavior
Passing test suite.
Perl configuration
The text was updated successfully, but these errors were encountered: