t/op/glob.t - defend against ls with colors enabled #21157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable any ENV vars with the word "color", "ls" or "cli" in them (case insensitively) before running ls. This appears to mostly be a BSD/darwin issue, but we do it on all platforms where we call ls in an abundance of caution. Fixes #21156.
|
FWIW, this is intended to be a minimal change to this file. I would prefer we rewrote it to have better diagnostics and to properly isolate %ENV var settings for all platforms, not just those using ls. but I didnt want to do that large a change before 5.38.0 |
|
Building this branch on FreeBSD, with these altered environmental settings: ... |
Thanks! |
|
Thanks, applied! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable any ENV vars with the word "color", "ls" or "cli" in them (case insensitively) before running ls. This appears to mostly be a BSD/darwin issue, but we do it on all platforms where we call ls in an abundance of caution.
Fixes #21156.