Skip to content

JIT: Align func for trace JIT exit stubs #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

PeterYang12
Copy link
Owner

Fixed phpGH-11120

@iluuu1994
Copy link

/cc @dstogov. Can you comment on if this makes sense?

Copy link

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, exit groups are already always aligned (because of luck).
Anyway, this won't make any harm.

@iluuu1994
Copy link

Note that the failures look legit.

@dstogov
Copy link

dstogov commented Apr 27, 2023

Note that the failures look legit.

I see. :(
It seems like exit groups are not always aligned now.
Their alignment requires the resulting entry adjustment.

Copy link

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

entry have to be aligned.
Tests need to fixed.

@iluuu1994
Copy link

Oh, sorry. I didn't even realize this PR was added to the fork. I followed the link from the issue. Sorry is this was intended for personal purposes.

@dstogov
Copy link

dstogov commented Apr 27, 2023

@ iluuu1994 I also didn't notice the target :)

@PeterYang12
Copy link
Owner Author

ollowed the link from the issue. Sorry is this was inte

It's my fault. This was not intended for personal purposes. I just to see the CI result if adding this alignment before I file a formal PR.
Besides, thanks too much to Dmitry and you for your observant comments.
According to the comments above, it makes sense to do it right? Let me find a proper way to do it and fix the CI tests above. I will file a PR later.
Thanks again @iluuu1994 @dstogov.

@PeterYang12 PeterYang12 closed this May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opcache: zend_jit_align_func for trace_exit_group_stub
3 participants