Skip to content

Opcache: zend_jit_align_func for trace_exit_group_stub #11120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PeterYang12 opened this issue Apr 23, 2023 · 1 comment · Fixed by #11149
Closed

Opcache: zend_jit_align_func for trace_exit_group_stub #11120

PeterYang12 opened this issue Apr 23, 2023 · 1 comment · Fixed by #11149

Comments

@PeterYang12
Copy link
Contributor

PeterYang12 commented Apr 23, 2023

Description

Hi, maintainers, I saw JIT will do zend_jit_align_func(&dasm_state); at the beginning of each JIT.
But JIT doesn't do the same operation when allocating exit groups. See here https://github.com/php/php-src/blob/master/ext/opcache/jit/zend_jit_trace.c#L97
Is there any special reason why not to do this?
I would like to provide a patch to add this support if missing unwittingly.

PeterYang12 added a commit to PeterYang12/php-src that referenced this issue Apr 23, 2023
PeterYang12 added a commit to PeterYang12/php-src that referenced this issue Apr 28, 2023
Fixed phpGH-11120

Signed-off-by: PeterYang12 <[email protected]>
@PeterYang12
Copy link
Contributor Author

Filed a PR to track this issue. #11149

PeterYang12 added a commit to PeterYang12/php-src that referenced this issue Apr 28, 2023
Fixed phpGH-11120

Signed-off-by: PeterYang12 <[email protected]>
dstogov pushed a commit that referenced this issue May 2, 2023
Fixed GH-11120

Signed-off-by: PeterYang12 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant