Skip to content

Conversation

viktorku
Copy link

The build and install directories should not pollute the git workspace.

@taketwo
Copy link
Member

taketwo commented Jun 23, 2017

See #745.
Though maybe we can revise that decision. E.g. OpenCV does have build in the ignore list.

@SergioRAgostinho
Copy link
Member

Those folders don't exist in our repo, that's on the user side so I'm not sure it makes sense to add it our gitignore. I think this PR is unnecessary.

@taketwo
Copy link
Member

taketwo commented Jun 23, 2017

I would speculate that 99% use build directory, whereas the percentage of those who know about .git/info/exclude and can "locally" ignore a directory is way lower. So many people end up having "dirty" state in their repos.

Are there any serious arguments against having build in the global .gitignore?

@SergioRAgostinho
Copy link
Member

Are there any serious arguments against having build in the global .gitignore?

Not from my side.

@jspricke
Copy link
Member

-1 from me, Just ad it locally if it enoyes you.

@viktorku
Copy link
Author

those who know about .git/info/exclude and can "locally" ignore a directory

If an open source project creates additional artifacts by compilation with default flags, and those are not supposed to be included in the repo, what is the problem by ignoring them? That is by definition the purpose of .gitignore.

Why does every potential contributor have to manually dabble in the repo's .git exclusion settings after each fork/clone to ignore something that should have been ignored out-of-the-box?

@jspricke
Copy link
Member

Because these names are completely arbitrary and don't need to be in the source folder.

@SergioRAgostinho
Copy link
Member

Can I close this? I agree with @jspricke on this, the user decides where he wants to build the cache and install it, and since this is can be completely arbitrary, it doesn't make sense to specify these folders in the git ignore.

@taketwo taketwo closed this Jun 29, 2017
@jspricke jspricke mentioned this pull request Sep 29, 2018
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants