Skip to content

Conversation

VictorLamoine
Copy link
Contributor

No description provided.

@xiangxw
Copy link
Contributor

xiangxw commented Jun 12, 2014

Is it ok to set this to build*/ so that we can have multiple builds? Thanks.

@VictorLamoine
Copy link
Contributor Author

It might be a problem if a folder in PCL is named 'building' etc..
It's not a good idea in my opinion.

Here is a little trick; Put this in your .gitignore :

build/
my_second_build/
my_third_build/
.gitgnore

This way gitignore will ignore .gitgnore... 😄

@xiangxw
Copy link
Contributor

xiangxw commented Jun 12, 2014

I mean build*/, not *build/. With build*/, we can have builds like:

build/
build-debug/
build-release/

This won't be a problem if a file in PCL is named 'blablabuild"

@xiangxw
Copy link
Contributor

xiangxw commented Jun 12, 2014

By the way, it's great to make gitignore ignore .gitgnore 👍

@VictorLamoine
Copy link
Contributor Author

I updated my comment too, building is a problem if it is a folder!

@xiangxw
Copy link
Contributor

xiangxw commented Jun 12, 2014

yes, you are right. thanks. 😄

@jspricke
Copy link
Member

I have build dirs outside of the git repo (on an SSD) and different names as well. As it's hard to predict the name and on the other and easy to just have a gitignore locally, I vote against this pull request.

@VictorLamoine
Copy link
Contributor Author

The official instructions makes the user create a build folder inside PCL git repo:
http://www.pointclouds.org/downloads/source.html

Well it's not a big deal; if you don't want it let's drop the idea

@jspricke
Copy link
Member

It's only my vote, if others want it, I'm ok as well ;).

@taketwo
Copy link
Member

taketwo commented Jun 12, 2014

This way gitignore will ignore .gitgnore...

There is a special file where you can put your own ignores: .git/info/exclude.

I'm also against. If it was the case that absolutely everyone uses build/, then it would make sense. But from this discussion it is obvious that that is not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants