Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 1 addition & 21 deletions visualization/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ set(SUBSYS_DESC "Point cloud visualization library")
set(SUBSYS_DEPS common io kdtree geometry search octree)

PCL_SUBSYS_OPTION(build "${SUBSYS_NAME}" "${SUBSYS_DESC}" ON)
PCL_SUBSYS_DEPEND(build NAME ${SUBSYS_NAME} DEPS ${SUBSYS_DEPS} EXT_DEPS vtk OPT_DEPS openni openni2 ensenso davidSDK dssdk rssdk)
PCL_SUBSYS_DEPEND(build NAME ${SUBSYS_NAME} DEPS ${SUBSYS_DEPS} EXT_DEPS vtk)

if(ANDROID)
message("VTK was found, but cannot be compiled for Android. Please use VES instead.")
Expand Down Expand Up @@ -212,26 +212,6 @@ if(HAVE_QVTK)
endif()
endif()

set(EXT_DEPS "")
if(WITH_OPENNI)
list(APPEND EXT_DEPS libopenni)
endif()
if(WITH_OPENNI2)
list(APPEND EXT_DEPS libopenni2)
endif()
if(WITH_ENSENSO)
list(APPEND EXT_DEPS ensenso)
endif()
if(WITH_DAVIDSDK)
list(APPEND EXT_DEPS davidSDK)
endif()
if(WITH_DSSDK)
list(APPEND EXT_DEPS dssdk)
endif()
if(WITH_RSSDK)
list(APPEND EXT_DEPS rssdk)
endif()

PCL_MAKE_PKGCONFIG(${LIB_NAME} COMPONENT ${SUBSYS_NAME} DESC ${SUBSYS_DESC} PCL_DEPS ${SUBSYS_DEPS} EXT_DEPS ${EXT_DEPS})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EXT_DEPS variable is now empty/undefined here. Is there a reason why vtk is not listed in there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its set in the top in line 6.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what you mean -- in line 6, vtk is passed as the EXT_DEPS parameter of the PCL_SUBSYS_DEPEND macro, but I do not see how that would set the variable EXT_DEPS here.
However, I believe it is correct that vtk is not passed as the EXT_DEPS parameter to PCL_MAKE_PKGCONFIG because there is no file vtk.pc (compare e.g. #5110 ). So it seems to me that the EXT_DEPS parameter should simply be removed from PCL_MAKE_PKGCONFIG?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PCL_MAKE_PKGCONFIG(${LIB_NAME} COMPONENT ${SUBSYS_NAME} DESC ${SUBSYS_DESC} PCL_DEPS ${SUBSYS_DEPS} EXT_DEPS ${EXT_DEPS})
PCL_MAKE_PKGCONFIG(${LIB_NAME} COMPONENT ${SUBSYS_NAME} DESC ${SUBSYS_DESC} PCL_DEPS ${SUBSYS_DEPS})


# Install include files
Expand Down