-
Notifications
You must be signed in to change notification settings - Fork 41
Closed
Labels
featureNew feature or requestNew feature or requestgood first issueIndicates a good issue for first-time contributorsIndicates a good issue for first-time contributors
Description
Describe the feature request
Add a Nightly build that runs a full clang-tidy compilation on all targets, including the benchmark, package tests, etc.
Background
Due to compilation time, the following decisions were made in the past:
- In Feature/reduce clang tidy build #345 , the clang-tidy build was restricted to the C API, and building clang-tidy on the tests was disabled from every PR and
main
build. - During Feature/Re route validation tests #718 , it was decided to remove the benchmark build from every PR and from every
main
build.
The downside of those decisions is, that there is the danger that the omitted parts of the compilation break and that that is unnoticed.
This feature will introduce a Nightly build that re-enables those checks
Desired implementation
- exclude build target
power_grid_model_benchmark_cpp
from theALL
target usingEXCLUDE_FROM_ALL
- add
all power_grid_model_benchmark_cpp
to theoptions
for thetarget
inputs
for theworkflow_dispatch
in.github/workflows/clang-tidy.yml
- This is possible cfr. https://cmake.org/cmake/help/latest/manual/cmake.1.html#cmdoption-cmake-build-t
- enable
on
workflow_call
for.github/workflows/nightly.yml
and.github/workflows/clang-tidy.yml
cfr. https://docs.github.com/en/actions/sharing-automations/reusing-workflows - add
.github/workflows/nightly.yml
- call
.github/workflows/main.yml
and.github/workflows/clang-tidy.yml
from this workflow cfr. https://docs.github.com/en/actions/sharing-automations/reusing-workflows
- call
Jerry-Jinfeng-Guo
Metadata
Metadata
Assignees
Labels
featureNew feature or requestNew feature or requestgood first issueIndicates a good issue for first-time contributorsIndicates a good issue for first-time contributors