Skip to content

Feature/reduce clang tidy build #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 9, 2023
Merged

Feature/reduce clang tidy build #345

merged 11 commits into from
Aug 9, 2023

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Aug 9, 2023 •
edited
Loading

Not fond of it but this is the only way to improve the compile time for clang tidy without matrix testing for build target

  • only build the C API target for clang tidy by default
  • add manual trigger option to override the target

@mgovers mgovers added the improvement Improvement on internal implementation label Aug 9, 2023
@mgovers mgovers requested a review from TonyXiang8787 August 9, 2023 06:38
@mgovers mgovers self-assigned this Aug 9, 2023
@mgovers
fix
e82f641 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers mgovers marked this pull request as ready for review August 9, 2023 06:50
TonyXiang8787
TonyXiang8787 previously approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@TonyXiang8787 TonyXiang8787 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Now it is down to 6 minutes.

@mgovers
Copy link
Member Author

mgovers commented Aug 9, 2023

c.c. @Laurynas-Jagutis I added a workflow-dispatch trigger in which you can override the build target to all.

Unfortunately, I cannot test this until it's in main because of how github actions work

TonyXiang8787
TonyXiang8787 reviewed Aug 9, 2023
View reviewed changes
@mgovers mgovers marked this pull request as draft August 9, 2023 07:11
mgovers added 3 commits August 9, 2023 09:12
@mgovers
check that override works correctly
c2b88df 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
workflow dispatch
3a7c442 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
attempt #2
9f13abc 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers mgovers force-pushed the feature/reduce-clang-tidy-build branch from 8db705f to 9f13abc Compare August 9, 2023 07:21
@mgovers mgovers marked this pull request as ready for review August 9, 2023 07:24
@mgovers
cleanup
e167c20 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers mgovers force-pushed the feature/reduce-clang-tidy-build branch from 47e3fcc to e167c20 Compare August 9, 2023 07:25
TonyXiang8787
TonyXiang8787 previously approved these changes Aug 9, 2023
View reviewed changes
mgovers
mgovers commented Aug 9, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mgovers mgovers merged commit ca47ef6 into main Aug 9, 2023
@mgovers mgovers deleted the feature/reduce-clang-tidy-build branch August 9, 2023 08:55
@mgovers mgovers mentioned this pull request Sep 25, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyXiang8787 TonyXiang8787 TonyXiang8787 approved these changes

@Laurynas-Jagutis Laurynas-Jagutis Awaiting requested review from Laurynas-Jagutis

Assignees

@mgovers mgovers

Labels
improvement Improvement on internal implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgovers @TonyXiang8787