-
Notifications
You must be signed in to change notification settings - Fork 13
fix: Correctly compare Enum
s in matches
#141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 49 49
Lines 2818 2826 +8
=========================================
+ Hits 2818 2826 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing! I guess it would also be an argument to represent enum categories as lists instead of series though 👀
Motivation
Fixes #140
Changes
matches
that properly comparespl.Series
rather than relying on==