Skip to content

Conversation

AndreasAlbertQC
Copy link
Collaborator

Motivation

Fixes #140

Changes

  • Added logic in matches that properly compares pl.Series rather than relying on ==

Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (22f4b7d) to head (0f90c3b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #141   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         2818      2826    +8     
=========================================
+ Hits          2818      2826    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@borchero borchero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! I guess it would also be an argument to represent enum categories as lists instead of series though 👀

@AndreasAlbertQC AndreasAlbertQC merged commit a24ab34 into main Sep 11, 2025
22 checks passed
@AndreasAlbertQC AndreasAlbertQC deleted the fix-enum-match branch September 11, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column matches is broken for dy.Enum
2 participants