-
Notifications
You must be signed in to change notification settings - Fork 13
ci: Add tests for serialization and printing of dy.Enum
columns
#147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 50 50
Lines 2851 2841 -10
=========================================
- Hits 2851 2841 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dy.Enum
columnsdy.Enum
columns
@borchero @AndreasAlbertQC this fixes the current state, but is maybe also an extra argument for this approach. Up to you how we fix it. I am also not sure whether there are any other similar issues left that we did not run into yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the second issue that we've run into after using Series
instead of list
here, let's please store the categories as list
😅 fyi @AndreasAlbertQC
EDIT: Sorry, didn't see your additional comment @MoritzPotthoffQC, I agree
Could not agree more |
dy.Enum
columnsdy.Enum
columns
This PR is now based on #150, which fixes the underlying problems. I still want to merge this PR to get the tests. |
Merge after #150
Motivation
The possible values are now stored as
pl.Series
(#138), which can't be json-serialized and breakrepr
as the check against the default argument now produces a series object (element-wise comparison) which can't be evaluated as boolean. This means that in these methods, we always treatcategories
aslist
(even when they are actually apl.Series
). I am not sure if this has any undesired effects.Changes
__repr__